Skip to content

[deploy] 운영 서버 배포#206

Merged
buzz0331 merged 1 commit intomainfrom
develop
Aug 12, 2025
Merged

[deploy] 운영 서버 배포#206
buzz0331 merged 1 commit intomainfrom
develop

Conversation

@buzz0331
Copy link
Contributor

@buzz0331 buzz0331 commented Aug 12, 2025

#️⃣ 연관된 이슈

closes #이슈번호

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

📸 스크린샷

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

📌 PR 진행 시 이러한 점들을 참고해 주세요

* P1 : 꼭 반영해 주세요 (Request Changes) - 이슈가 발생하거나 취약점이 발견되는 케이스 등
* P2 : 반영을 적극적으로 고려해 주시면 좋을 것 같아요 (Comment)
* P3 : 이런 방법도 있을 것 같아요~ 등의 사소한 의견입니다 (Chore)

Summary by CodeRabbit

  • 버그 수정
    • HTTPS 환경에서 간헐적으로 로그인 쿠키가 설정되지 않거나 세션이 유지되지 않던 현상을 수정했습니다.
    • thip.co.kr의 서브도메인 간 이동 시 로그인 상태가 일관되게 유지되도록 개선했습니다.
    • 일부 브라우저에서 재방문 시 불필요하게 재로그인이 요구되던 사례를 줄였습니다.
    • 브라우저·네트워크 환경에 따른 로그인 유지 동작의 차이를 완화해 전반적인 안정성을 높였습니다.

@buzz0331 buzz0331 self-assigned this Aug 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

OAuth2 로그인 성공 시 토큰 쿠키 설정 로직에서 도메인 결정과 secure 플래그 설정 방식을 정규화했다. HTTPS일 때 도메인을 ".thip.co.kr", 비-HTTPS일 때 "localhost"로 고정하며, secure 설정은 webRedirectUrl의 스킴을 기준으로 단일 지점에서 계산한다.

Changes

Cohort / File(s) Summary
OAuth2 Success Handler
src/main/java/konkuk/thip/common/security/oauth2/CustomSuccessHandler.java
쿠키 도메인을 HTTPS: ".thip.co.kr", 비-HTTPS: "localhost"로 고정. 분기별 cookie.setSecure 호출 제거 후 단일 cookie.setSecure(...)로 통합. 공개 API 시그니처 변화 없음.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

🌈 infra, ⚡️ fix

Suggested reviewers

  • seongjunnoh

Poem

토끼는 쿠키 굽고 펄쩍! 펄쩍!
도메인 딱 맞춰, 보안은 척척!
HTTPS면 .thip에 살포시 앉고,
로컬에선 localhost로 살랑 뛰고.
한 줄 secure로 흐름은 쏙—정리 끝!
밤하늘 별도 OK라며 깜빡-🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ad2a7d and 25b8500.

📒 Files selected for processing (1)
  • src/main/java/konkuk/thip/common/security/oauth2/CustomSuccessHandler.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@buzz0331 buzz0331 merged commit ec8be49 into main Aug 12, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant