Wrap longitude, 0-360, where it is used directly.#86
Merged
efiring merged 1 commit intoTEOS-10:masterfrom Dec 29, 2021
Merged
Conversation
Closes TEOS-10#85. For functions that take a longitude argument but merely pass it to another function, we leave the argument as-is.
Member
Author
|
A note on the test: It cycles through all the check functions, adding and subtracting 360 from longitude in the check cast. It's overkill in testing functions that don't take a longitude argument, but it's fast enough, and simple. |
ocefpaf
approved these changes
Dec 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #85.
For functions that take a longitude argument but merely pass it to
another function, we leave the argument as-is.