Skip to content

Bring lons outside of [0, 360) into range#47

Merged
efiring merged 1 commit intoTEOS-10:masterfrom
DocOtak:lon_wrap
Dec 28, 2021
Merged

Bring lons outside of [0, 360) into range#47
efiring merged 1 commit intoTEOS-10:masterfrom
DocOtak:lon_wrap

Conversation

@DocOtak
Copy link
Contributor

@DocOtak DocOtak commented Dec 27, 2021

This is an attempt at solving #46 including tests.

There were 4 places that an fmod call appeared to be needed, the two saar lookup functions, and the Baltic sea specific functions.

It does not appear to be immediately needed in gsw_add_barrier as that is only called by the saar functions which already are brought into range by this PR.

@efiring
Copy link
Member

efiring commented Dec 27, 2021

TEOS-10/GSW-Python#86 has the same fix in C, and the Python test.

Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@efiring efiring merged commit 98f0fd4 into TEOS-10:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants