Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for GetAuthInfoActionTest #13273

Merged
merged 5 commits into from
Mar 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/teammates/ui/webapi/GetAuthInfoAction.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*
* <p>This does not log in or log out the user.
*/
class GetAuthInfoAction extends Action {
public class GetAuthInfoAction extends Action {

@Override
public AuthType getMinAuthLevel() {
Expand Down Expand Up @@ -67,7 +67,10 @@ public JsonResult execute() {
return new JsonResult(output, cookieList);
}

String createLoginUrl(String frontendUrl, String nextUrl) {
/**
* Returns a LoginURL based on the frontendURL and nextURL.
*/
public static String createLoginUrl(String frontendUrl, String nextUrl) {
return Const.WebPageURIs.LOGIN + "?nextUrl=" + frontendUrl + nextUrl;
}

Expand Down
182 changes: 182 additions & 0 deletions src/test/java/teammates/sqlui/webapi/GetAuthInfoActionTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,182 @@
package teammates.sqlui.webapi;

import static teammates.ui.webapi.GetAuthInfoAction.createLoginUrl;

import java.util.ArrayList;
import java.util.Arrays;

import jakarta.servlet.http.Cookie;

import org.testng.annotations.Test;

import teammates.common.datatransfer.UserInfo;
import teammates.common.util.Const;
import teammates.common.util.StringHelper;
import teammates.ui.output.AuthInfo;
import teammates.ui.webapi.GetAuthInfoAction;
import teammates.ui.webapi.JsonResult;

/**
* SUT: {@link GetAuthInfoAction}.
*/
public class GetAuthInfoActionTest extends BaseActionTest<GetAuthInfoAction> {

@Override
String getActionUri() {
return Const.ResourceURIs.AUTH;
}

@Override
String getRequestMethod() {
return GET;
}

@Test
void testExecute_noLoggedInUser() {
logoutUser();

GetAuthInfoAction a = getAction();
JsonResult r = getJsonResult(a);

AuthInfo output = (AuthInfo) r.getOutput();
assertEquals(createLoginUrl("", Const.WebPageURIs.STUDENT_HOME_PAGE), output.getStudentLoginUrl());
assertEquals(createLoginUrl("", Const.WebPageURIs.INSTRUCTOR_HOME_PAGE), output.getInstructorLoginUrl());
assertEquals(createLoginUrl("", Const.WebPageURIs.ADMIN_HOME_PAGE), output.getAdminLoginUrl());
assertEquals(createLoginUrl("", Const.WebPageURIs.MAINTAINER_HOME_PAGE), output.getMaintainerLoginUrl());
assertNull(output.getUser());
assertFalse(output.isMasquerade());
}

@Test
void testExecute_noLoggedInUser_hasNextUrlParameter() {
logoutUser();
String nextUrl = "/web/join";

String[] params = new String[] {
"nextUrl", nextUrl,
};

GetAuthInfoAction a = getAction(params);
JsonResult r = getJsonResult(a);

AuthInfo output = (AuthInfo) r.getOutput();
assertEquals(createLoginUrl("", nextUrl), output.getStudentLoginUrl());
assertEquals(createLoginUrl("", nextUrl), output.getInstructorLoginUrl());
assertEquals(createLoginUrl("", nextUrl), output.getAdminLoginUrl());
assertEquals(createLoginUrl("", nextUrl), output.getMaintainerLoginUrl());
assertNull(output.getUser());
assertFalse(output.isMasquerade());
}

@Test
void testExecute_loggedInAsInstructor() {
loginAsInstructor("idOfInstructor1OfCourse1");

GetAuthInfoAction a = getAction();
JsonResult r = getJsonResult(a);

AuthInfo output = (AuthInfo) r.getOutput();
assertNull(output.getStudentLoginUrl());
assertNull(output.getInstructorLoginUrl());
assertNull(output.getAdminLoginUrl());
assertNull(output.getMaintainerLoginUrl());
assertFalse(output.isMasquerade());

UserInfo user = output.getUser();
assertFalse(user.isAdmin);
assertTrue(user.isInstructor);
assertFalse(user.isStudent);
assertEquals("idOfInstructor1OfCourse1", user.id);
}

@Test
void testExecute_loggedInAsUnregisteredUser() {
loginAsUnregistered("unregisteredId");

GetAuthInfoAction a = getAction();
JsonResult r = getJsonResult(a);

AuthInfo output = (AuthInfo) r.getOutput();
assertNull(output.getStudentLoginUrl());
assertNull(output.getInstructorLoginUrl());
assertNull(output.getAdminLoginUrl());
assertNull(output.getMaintainerLoginUrl());
assertFalse(output.isMasquerade());

UserInfo user = output.getUser();
assertFalse(user.isAdmin);
assertFalse(user.isInstructor);
assertFalse(user.isStudent);
assertEquals("unregisteredId", user.id);
}

@Test
public void testExecute_addCsrfTokenCookies_shouldAddToResponseAccordingToExistingCsrfToken() {
String expectedCsrfToken = StringHelper.encrypt("1234");
String[] emptyParams = new String[] {};

______TS("No logged in user");

logoutUser();

GetAuthInfoAction a = getAction(emptyParams);
JsonResult r = getJsonResult(a);

assertEquals(expectedCsrfToken, r.getCookies().get(0).getValue());

______TS("User logged in with fake csrf token");

Cookie cookieToAdd = new Cookie(Const.SecurityConfig.CSRF_COOKIE_NAME, "someFakeCsrfToken");

a = getActionWithCookie(new ArrayList<>(Arrays.asList(cookieToAdd)), emptyParams);
r = getJsonResult(a);

assertEquals(expectedCsrfToken, r.getCookies().get(0).getValue());

______TS("User logged in with non existing csrf token");

loginAsInstructor("idOfInstructor1OfCourse1");

a = getAction(emptyParams);
r = getJsonResult(a);

assertEquals(expectedCsrfToken, r.getCookies().get(0).getValue());

______TS("User logged in with matched CSRF token cookies");

loginAsInstructor("idOfInstructor1OfCourse1");

cookieToAdd = new Cookie(Const.SecurityConfig.CSRF_COOKIE_NAME,
StringHelper.encrypt("1234"));

a = getActionWithCookie(new ArrayList<>(Arrays.asList(cookieToAdd)), emptyParams);
r = getJsonResult(a);

assertEquals(0, r.getCookies().size());
}

@Test
void testAccessControl_adminCanAccess() {
loginAsAdmin();
verifyCanAccess();
}

@Test
void testAccessControl_unRegisteredUserCanAccess() {
loginAsUnregistered("unregistered user");
verifyCanAccess();
}

@Test
void testAccessControl_noLoginCanAccess() {
logoutUser();
verifyCanAccess();
}

@Test
void testAccessControl_nonAdminCannotMasquerade() {
loginAsInstructor("idOfInstructor1OfCourse1");
verifyCannotMasquerade("idOfAnotherInstructor");
}

}
Loading