-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12048] Migrate tests for GetAuthInfoActionTest #13273
Merged
jasonqiu212
merged 5 commits into
TEAMMATES:master
from
BunnyHoppp:branch-GetAuthInfoActionTest
Mar 22, 2025
Merged
[#12048] Migrate tests for GetAuthInfoActionTest #13273
jasonqiu212
merged 5 commits into
TEAMMATES:master
from
BunnyHoppp:branch-GetAuthInfoActionTest
Mar 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test execute method with some positive and negative test cases Test checkSpecificAccessControl method with some positive and negative test cases
jasonqiu212
reviewed
Mar 19, 2025
src/test/java/teammates/sqlui/webapi/GetAuthInfoActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/GetAuthInfoActionTest.java
Outdated
Show resolved
Hide resolved
Modify the accessibility of createLoginURL to be used in the test. Combined some test case for readability.
jasonqiu212
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the changes
domoberzin
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Change GetAuthInfoActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.
Excluded tests where admin masquerades as user, because the user database cannot be accessed in the test.