Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for GetAuthInfoActionTest #13273

Merged
merged 5 commits into from
Mar 22, 2025

Conversation

BunnyHoppp
Copy link
Contributor

@BunnyHoppp BunnyHoppp commented Mar 16, 2025

Part of #12048

Outline of Solution

Change GetAuthInfoActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.

Excluded tests where admin masquerades as user, because the user database cannot be accessed in the test.

Test execute method with some positive
and negative test cases

Test checkSpecificAccessControl method
with some positive and negative test
cases
Modify the accessibility of createLoginURL to be used in the test.

Combined some test case for readability.
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the changes

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Mar 21, 2025
@jasonqiu212 jasonqiu212 requested a review from mingyang143 March 21, 2025 12:21
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work on this

@domoberzin domoberzin added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 22, 2025
@jasonqiu212 jasonqiu212 merged commit 299204d into TEAMMATES:master Mar 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants