[#12048] Abstract Access Controls to BaseActionTest

src/main/java/teammates/ui/webapi/Action.java

@@ -155,7 +155,7 @@ protected boolean isAccountMigrated(String googleId) {
      */
     public void checkAccessControl() throws UnauthorizedAccessException {
         String userParam = getRequestParamValue(Const.ParamsNames.USER_ID);
-        if (userInfo != null && userParam != null && !userInfo.isAdmin && !userInfo.id.equals(userParam)) {
+        if (userInfo != null && userParam != null && !userInfo.isAdmin && !userParam.equals(userInfo.id)) {
             throw new UnauthorizedAccessException("User " + userInfo.id
                     + " is trying to masquerade as " + userParam + " without admin permission.");
         }

src/test/java/teammates/sqllogic/api/MockUserProvision.java

@@ -3,6 +3,8 @@
 import teammates.common.datatransfer.UserInfo;
 import teammates.common.datatransfer.UserInfoCookie;
 import teammates.logic.api.UserProvision;
+import teammates.logic.core.InstructorsLogic;
+import teammates.sqllogic.core.UsersLogic;
 
 /**
  * Allows mocking of the {@link UserProvision} API used in production.
@@ -13,6 +15,10 @@
 public class MockUserProvision extends UserProvision {
     private UserInfo mockUser = new UserInfo("user.id");
     private boolean isLoggedIn;
+    private boolean isMaintainer;
+    private boolean isAdmin;
+    private boolean isInstructor;
+    private boolean isStudent;
 
     private UserInfo loginUser(String userId, boolean isAdmin, boolean isInstructor, boolean isStudent,
             boolean isMaintainer) {
@@ -100,4 +106,31 @@ public UserInfo getCurrentLoggedInUser(UserInfoCookie uic) {
     public UserInfo getCurrentUserWithTransaction(UserInfoCookie uic) {
         return getCurrentUser(uic);
     }
+
+    @Override
+    public UserInfo getMasqueradeUser(String googleId) {
+        UserInfo userInfo = new UserInfo(googleId);
+        userInfo.isAdmin = isAdmin;
+        userInfo.isInstructor = isInstructor;
+        userInfo.isStudent = isStudent;
+        userInfo.isMaintainer = isMaintainer;
+
+        return userInfo;
+    }
+
+    public void setAdmin(boolean isAdmin) {
+        this.isAdmin = isAdmin;
+    }
+
+    public void setInstructor(boolean isInstructor) {
+        this.isInstructor = isInstructor;
+    }
+
+    public void setStudent(boolean isStudent) {
+        this.isStudent = isStudent;
+    }
+
+    public void setMaintainer(boolean isMaintainer) {
+        this.isMaintainer = isMaintainer;
+    }
 }