[#12048] Abstract Access Controls to BaseActionTest #13254
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfinityTwo
force-pushed
the
db-migration-access-control
branch
from
55352ca to
b821e81
Compare
…nityTwo/Teammates into origin/db-migration-access-control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Surfaced from #13245
Outline of Solution
Abstract various access controls for testing to BaseActionTest, like the previous way, to simplify test code.
Issue not yet resolved, but the concern now is implementing
verifyAccessibleForInstructorsOfTheSameCourse()and its similar counterparts as the previous implementation is based on typical bundle course and instructor ids. If any of the test cases do not use the same course/instructors, then the method and test will not be testing the same thing.PS: I'm not sure why the first 10 commits are there even though I started from a clean master but they are not relevant to the PR.