[#12048] Migrate tests for CreateAccountRequestActionTest

src/test/java/teammates/sqllogic/api/MockUserProvision.java

@@ -96,4 +96,8 @@ public UserInfo getCurrentLoggedInUser(UserInfoCookie uic) {
         return isLoggedIn ? mockUser : null;
     }
 
+    @Override
+    public UserInfo getCurrentUserWithTransaction(UserInfoCookie uic) {
+        return getCurrentUser(uic);
+    }
 }

src/test/java/teammates/sqlui/webapi/BaseActionTest.java

@@ -22,7 +22,6 @@
 import teammates.common.util.JsonUtils;
 import teammates.logic.api.MockEmailSender;
 import teammates.logic.api.MockLogsProcessor;
-import teammates.logic.api.MockRecaptchaVerifier;
 import teammates.logic.api.MockTaskQueuer;
 import teammates.sqllogic.api.Logic;
 import teammates.sqllogic.api.MockUserProvision;
@@ -61,7 +60,7 @@ public abstract class BaseActionTest<T extends Action> extends BaseTestCase {
     MockEmailSender mockEmailSender = new MockEmailSender();
     MockLogsProcessor mockLogsProcessor = new MockLogsProcessor();
     MockUserProvision mockUserProvision = new MockUserProvision();
-    MockRecaptchaVerifier mockRecaptchaVerifier = new MockRecaptchaVerifier();
+    teammates.logic.api.RecaptchaVerifier mockRecaptchaVerifier = mock(teammates.logic.api.RecaptchaVerifier.class);
     SqlEmailGenerator mockSqlEmailGenerator = mock(SqlEmailGenerator.class);
 
     abstract String getActionUri();

src/test/java/teammates/sqlui/webapi/CreateAccountRequestActionTest.java

@@ -0,0 +1,188 @@
+package teammates.sqlui.webapi;
+
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import teammates.common.datatransfer.AccountRequestStatus;
+import teammates.common.exception.InvalidParametersException;
+import teammates.common.util.Const;
+import teammates.storage.sqlentity.AccountRequest;
+import teammates.ui.output.AccountRequestData;
+import teammates.ui.request.AccountCreateRequest;
+import teammates.ui.request.InvalidHttpRequestBodyException;
+import teammates.ui.webapi.CreateAccountRequestAction;
+
+/**
+ * SUT: {@link CreateAccountRequestAction}.
+ */
+public class CreateAccountRequestActionTest extends BaseActionTest<CreateAccountRequestAction> {
+
+    private AccountCreateRequest createRequest;
+
+    @Override
+    protected String getActionUri() {
+        return Const.ResourceURIs.ACCOUNT_REQUEST;
+    }
+
+    @Override
+    protected String getRequestMethod() {
+        return POST;
+    }
+
+    @BeforeMethod
+    void setUp() {
+        createRequest = getTypicalAccountCreateRequest();
+    }
+
+    @AfterMethod
+    void tearDown() {
+        reset(mockRecaptchaVerifier);
+        reset(mockLogic);
+        logoutUser();
+    }
+
+    @Test
+    void testExecute_nullInstructorName_throwsInvalidHttpRequestBodyException() {
+        createRequest.setInstructorName(null);
+
+        InvalidHttpRequestBodyException ex = verifyHttpRequestBodyFailure(createRequest);
+        assertEquals("name cannot be null", ex.getMessage());
+        verifyNoTasksAdded();
+        verifyNoEmailsSent();
+    }
+
+    @Test
+    void testExecute_nullInstructorEmail_throwsInvalidHttpRequestBodyException() {
+        createRequest.setInstructorEmail(null);
+
+        InvalidHttpRequestBodyException ex = verifyHttpRequestBodyFailure(createRequest);
+        assertEquals("email cannot be null", ex.getMessage());
+        verifyNoTasksAdded();
+        verifyNoEmailsSent();
+    }
+
+    @Test
+    void testExecute_nullInstructorInstitution_throwsInvalidHttpRequestBodyException() {
+        createRequest.setInstructorInstitution(null);
+
+        InvalidHttpRequestBodyException ex = verifyHttpRequestBodyFailure(createRequest);
+        assertEquals("institute cannot be null", ex.getMessage());
+        verifyNoTasksAdded();
+        verifyNoEmailsSent();
+    }
+
+    @Test
+    void testExecute_validAccountCreateRequest_success() throws InvalidParametersException {
+        String instructorEmail = "jamesbond89@gmail.tmt";
+        String instructorName = "JamesBond";
+        String instructorInstitution = "TEAMMATES Test Institute 1";
+        String instructorComments = "comments";
+        AccountRequest accountRequest = new AccountRequest(instructorEmail, instructorName, instructorInstitution,
+                AccountRequestStatus.PENDING, instructorComments);
+
+        when(mockRecaptchaVerifier.isVerificationSuccessful(createRequest.getCaptchaResponse())).thenReturn(true);
+        when(mockLogic.createAccountRequestWithTransaction(instructorName, instructorEmail, instructorInstitution,
+                AccountRequestStatus.PENDING, instructorComments)).thenReturn(accountRequest);
+
+        CreateAccountRequestAction action = getAction(createRequest);
+        AccountRequestData output = (AccountRequestData) getJsonResult(action).getOutput();
+
+        verify(mockRecaptchaVerifier).isVerificationSuccessful(createRequest.getCaptchaResponse());
+        verifyAccountRequestCreated(output, accountRequest);
+        verifySpecifiedTasksAdded(Const.TaskQueue.SEARCH_INDEXING_QUEUE_NAME, 1);
+        verifyNumberOfEmailsSent(2);
+    }
+
+    @Test
+    void testExecute_invalidCaptcha_throwsInvalidHttpRequestBodyException() {
+        when(mockRecaptchaVerifier.isVerificationSuccessful(createRequest.getCaptchaResponse())).thenReturn(false);
+
+        InvalidHttpRequestBodyException ex = verifyHttpRequestBodyFailure(createRequest);
+        assertEquals("Something went wrong with the reCAPTCHA verification. Please try again.", ex.getMessage());
+        verify(mockRecaptchaVerifier).isVerificationSuccessful(createRequest.getCaptchaResponse());
+        verifyNoTasksAdded();
+        verifyNoEmailsSent();
+    }
+
+    @Test
+    void testExecute_createAccountRequestWithTransactionThrows_throwsInvalidHttpRequestBodyException()
+            throws InvalidParametersException {
+        String instructorEmail = "jamesbond89@gmail.tmt";
+        String instructorName = "JamesBond";
+        String instructorInstitution = "TEAMMATES Test Institute 1";
+        String instructorComments = "comments";
+
+        when(mockRecaptchaVerifier.isVerificationSuccessful(createRequest.getCaptchaResponse())).thenReturn(true);
+        when(mockLogic.createAccountRequestWithTransaction(instructorName, instructorEmail, instructorInstitution,
+                AccountRequestStatus.PENDING, instructorComments))
+                .thenThrow(new InvalidParametersException("test"));
+
+        InvalidHttpRequestBodyException ex = verifyHttpRequestBodyFailure(createRequest);
+        assertEquals("test", ex.getMessage());
+        verify(mockRecaptchaVerifier).isVerificationSuccessful(createRequest.getCaptchaResponse());
+        verifyNoTasksAdded();
+        verifyNoEmailsSent();
+    }
+
+    @Test
+    void testExecute_adminUser_bypassesCaptchaAndNoEmailSent() throws InvalidParametersException {
+        loginAsAdmin();
+        String instructorEmail = "jamesbond89@gmail.tmt";
+        String instructorName = "JamesBond";
+        String instructorInstitution = "TEAMMATES Test Institute 1";
+        String instructorComments = "comments";
+        AccountRequest accountRequest = new AccountRequest(instructorEmail, instructorName, instructorInstitution,
+                AccountRequestStatus.PENDING, instructorComments);
+
+        when(mockLogic.createAccountRequestWithTransaction(instructorName, instructorEmail, instructorInstitution,
+                AccountRequestStatus.PENDING, instructorComments)).thenReturn(accountRequest);
+
+        CreateAccountRequestAction action = getAction(createRequest);
+        AccountRequestData output = (AccountRequestData) getJsonResult(action).getOutput();
+
+        verify(mockRecaptchaVerifier, never()).isVerificationSuccessful(createRequest.getCaptchaResponse());
+        verifyAccountRequestCreated(output, accountRequest);
+        verifySpecifiedTasksAdded(Const.TaskQueue.SEARCH_INDEXING_QUEUE_NAME, 1);
+        verifyNumberOfEmailsSent(0);
+    }
+
+    @Test
+    void testExecute_invalidInstructorName_throwsInvalidHttpRequestBodyException() {
+        createRequest.setInstructorName("James%20Bond99");
+
+        InvalidHttpRequestBodyException ex = verifyHttpRequestBodyFailure(createRequest);
+        assertEquals("\"James%20Bond99\" is not acceptable to TEAMMATES as a/an person name because "
+                + "it contains invalid characters. A/An person name must start with an "
+                + "alphanumeric character, and cannot contain any vertical bar (|) or percent sign (%).",
+                ex.getMessage());
+        verifyNoTasksAdded();
+        verifyNoEmailsSent();
+    }
+
+    private AccountCreateRequest getTypicalAccountCreateRequest() {
+        AccountCreateRequest createRequest = new AccountCreateRequest();
+
+        createRequest.setInstructorEmail("  jamesbond89@gmail.tmt  ");
+        createRequest.setInstructorName("  JamesBond  ");
+        createRequest.setInstructorInstitution("  TEAMMATES Test Institute 1  ");
+        createRequest.setInstructorComments("  comments  ");
+
+        return createRequest;
+    }
+
+    private void verifyAccountRequestCreated(AccountRequestData output, AccountRequest accountRequest) {
+        assertEquals(output.getId(), accountRequest.getId().toString());
+        assertEquals(output.getEmail(), accountRequest.getEmail());
+        assertEquals(output.getName(), accountRequest.getName());
+        assertEquals(output.getInstitute(), accountRequest.getInstitute());
+        assertEquals(output.getRegistrationKey(), accountRequest.getRegistrationKey());
+        assertEquals(output.getStatus(), accountRequest.getStatus());
+        assertEquals(output.getComments(), accountRequest.getComments());
+    }
+}