Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate tests for CreateAccountRequestActionTest #13253

Merged
merged 8 commits into from
Mar 20, 2025
Merged

[#12048] Migrate tests for CreateAccountRequestActionTest #13253

merged 8 commits into from
Mar 20, 2025

Conversation

peasantbird
Copy link
Contributor

@peasantbird peasantbird commented Mar 3, 2025 •
edited
Loading

Part of #12048

Outline of Solution
Change CreateAccountRequestActionTest to ensure compatibility with the PostgreSQL database following the database migration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Hi @peasantbird, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]
  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@peasantbird peasantbird changed the title Add null test cases [#12048] Migrate tests for Create Mar 15, 2025
@peasantbird peasantbird changed the title [#12048] Migrate tests for Create [#12048] Migrate tests for CreateAccountRequestActionTest Mar 15, 2025
@peasantbird peasantbird force-pushed the migrate-create-account-request-action-test branch from bb88e90 to 97ba729 Compare March 15, 2025 16:55
@peasantbird peasantbird marked this pull request as ready for review March 16, 2025 15:12
@peasantbird peasantbird self-assigned this Mar 16, 2025
domoberzin
domoberzin approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for handling the transaction issues, i think the fix here will suffice, since only account requests use transactions at the moment, lgtm otherwise

@domoberzin domoberzin added the s.FinalReview The PR is ready for final review label Mar 20, 2025
jasonqiu212
jasonqiu212 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the fix

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 20, 2025
@jasonqiu212 jasonqiu212 merged commit e0cdb04 into TEAMMATES:master Mar 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@domoberzin domoberzin domoberzin approved these changes

@xenosf xenosf Awaiting requested review from xenosf

Assignees

@peasantbird peasantbird

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peasantbird @jasonqiu212 @domoberzin