Conversation
yogwoggf
reviewed
Dec 5, 2023
Contributor
yogwoggf
left a comment
There was a problem hiding this comment.
The code looks good to me, will try to QA as much as possible today.
Contributor
QA Result: Passed ✅✅ Passed
|
yogwoggf
approved these changes
Dec 10, 2023
Contributor
yogwoggf
left a comment
There was a problem hiding this comment.
Like the prior review, code is good and QA passed on my end, so I'm doing this to switch my review to "Approve"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #102, resolves #97, resolves #104
Changes
cli.luacommand line option handlingImpact
--luaCommandoption in the TypeScript wrappertestMatchfrom the command line with a comma separated list of patterns--helpoptionTesting
Some of the features implemented here can't be QA'd without implementing additional options (like
--watchfor booleans).lest --luaCommand=/path/to/luaruns lest using that executable without any errorslest --testMatch=pattern%.test%.luaruns the matching testslest --testTimeout=1runs tests with the given millisecond timeoutlest --testTimeout=notanumberdisplays a clean error message and exits with a non-zero status codelest --config=path/to/lest.config.luaruns lest with the given config-c=path/to/lest.config.lua--configoption is not set, tests are run with thelest.config.luain the working directorylest.config.luadoesn't exist in the working directory, then tests are run with default optionslest.config.luaHelpful Links
API Docs
Project Board
Discord