Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tup-ui): limit dashboard min height solution to wide & short screens #116

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 27, 2023

Overview & Changes

Limit dashboard body scroll solution to only screens that are wide and short**.

Related:

Testing

  1. Load dashboard.
  2. If you are a CMS admin, then—using "Inspect Element" tool—delete margin-top: 46px from <html>.
    That style is added dynamically by CMS admin to make room for the CMS admin header/toolbar.
  3. Verify scrollbar state at window sizes matches table data.

At given size (w x h), is scroll(bar) required to see footer?

px 1199– 1200+
899– no yes
900+ no no

UI

px 1199– 1200+
899– narrow short wide short
900+ narrow tall wide tall

wesleyboar and others added 5 commits January 27, 2023 12:48
I had slapped a min-height on Dashboard, to avoid dealing with mobile. With a real mobile solution implemented (#110), this lazy solution can be discarded.
@jarosenb jarosenb merged commit f0c3533 into main Jan 27, 2023
@jarosenb jarosenb deleted the task/dashboard-limit-short-height-ui-solution-to-narrow-screen branch January 27, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants