fix(tup-ui): remvove my lazy mobile dashboard #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had slapped a min-height on Dashboard, to avoid dealing with mobile. With a real mobile solution implemented (#110), this lazy solution can be discarded.
|
A wide and short screen has a goofy layout. This should be retained for wide layouts, but not narrow layouts. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview & Changes
Remove min-height on Dashboard i.e. discard my old lazy mobile UI solution, rely totally on #110.
Related:
Testing
margin-top: 46pxfrom<html>.That style is added dynamically by CMS admin to make room for the CMS admin header/toolbar.
UI
No Minimum Height
Ignore the different foot content. That is because my localhost footer is just a sentence.
Taller than 900px
Ignore the different foot content. That is because my localhost footer is just a sentence.
No Change