Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST6RI-724 Model library updates from SysML v2 FTF Ballot #9 #521

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

seidewitz
Copy link
Member

@seidewitz seidewitz commented Nov 30, 2023

This PR implements resolutions of issues from SysML v2 FTF Ballot 9 that called for updates to library models. In addition, it makes a further revision to TypeAdapter::removeUnnecessaryImplicitGeneralTypes (as already revised in PR #514) to ensure removal of implicit general types that are identical to explicit general types.

Resolutions of the following issues are implemented in this PR:

  • SYSML2-79 View::viewpointSatisfactions should subset viewpointChecks and checkedConstraints
  • SYSML2-83 Narrow down return types of SpatialItem::PositionOf and ::CurrentPositionOf
  • SYSML2-102 Semantic constraint for target of AssignmentActionUsage is missing
  • SYSML2-219 Action::decisionTransitions should subset Action::transitions
  • SYSML2-305 Message and flow connection ends should be occurrence usages [fully implemented]
  • SYSML2-490 Actions::acceptSubactions and sendSubactions should subset acceptActions and sendActions

Resolutions of the following issues were previously implemented in PRs #487, #504 and #506:

  • SYSML2-295 Causation end features need to redefine source and target
  • SYSML2-305 Message and flow connection ends should be occurrence usages [partially implemented]
  • SYSML2-491 KerML constraint requires updates to Systems Library Models
  • SYSML2-492 KerML constraint requires updates to Domain Library Models
  • SYSML2-497 validateTriggerInvocationExpressionAfterArgument constraint is too strong
  • SYSML2-498 validateTriggerInvocationExpressionWhenArgument constraint is wrong
  • SYSML2-500 The derivation of AssignmentActionUsage::referent is wrong

Resolutions of the following issues did not require any update to the library model files:

  • SYSML2-378 Sample::calculation has an incorrect type
  • SYSML2-393 Documentation of Time::defaultClock is missing
  • SYSML2-488 Constraints missing to enforce variations being abstract

An additional change was made later in PR #522 consistent with the preliminary resolution to the following issue:

  • SYSML2-182 Universal features can have many values

@seidewitz seidewitz self-assigned this Nov 30, 2023
@conradbock
Copy link
Contributor

  • action sendSubactions: SendAction[0..*] :> subactions, sendActions
    action acceptSubactions: AcceptAction[0..*] :> subactions, acceptActions
    For another issue, presumably these should be intersections, if SysML supports it.

  • Connections::FlowConnection, end indenting off.

@seidewitz
Copy link
Member Author

@conradbock

  • The SysML notation does not support intersection. And it is not actually necessary here, since these features are not modeled as "sufficient" but, instead, rely on semantic constraints determine their subsetting (like many other features in the semantic libraries).
  • The indentation is not consequential. However, I have updated Connections.sysml to consistently use spaces (rather than tabs) for indentation.

@conradbock
Copy link
Contributor

but, instead, rely on semantic constraints determine their subsetting

Do these require all M0 values of subactions that are also values of sendActions will be values of sendSubactions, and vice versa?

And it is not actually necessary here, since these features are not modeled as "sufficient"

Sufficiency doesn't require declaring intersection. It can be used instead of intersection, it's just less well-defined.

the SysML notation does not support intersection.

I figured. :)

@seidewitz
Copy link
Member Author

Do these require all M0 values of subactions that are also values of sendActions will be values of sendSubactions, and vice versa?

They require that all M1 send or accept action usages that are subactions of another action definition or usage subset sendSubactions or acceptSubactions. This may actually miss instances of SendAction and AcceptAction that are not declared using syntactic send or accept actions usages, but that is a general issue with the semantics constraints currently being based on syntactic structure, which can be addressed separately in the future.

@seidewitz seidewitz merged commit 8c07570 into master Dec 1, 2023
2 checks passed
@seidewitz seidewitz added this to the 2023-11 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants