ST6RI-709 Resolutions from SysML v2 FTF Ballot #6 #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also revised validation of binding connector typing to allow Expressions with Boolean results to conform to BooleanExpressions.
- Also revised the parsing of non-default initial feature values to be consistent with the specification (i.e., to *not* use FeatureWritePerformance/AssignmentActionUsage), in order to eliminate validation violations.
AssignmentActionUsage::referent.
Revised validateDefinitionVariationMembership to validateDefinitionVarationOwnedFeatureMembership and validateUsageVariationMembership to validateUsageVariationOwnedFeatureMembership, but the functionality is essentially the same as was already implemented.
- Removed the following: validateDefinitionNonVariationMembership validateUsageNonVariationMembership validateUsageOwningType validateStateDefinitionIsParallelGeneralization validateStateUsageIsParallelGeneralization - Since the code was already commented out, there is no change in functionality.
No change in functionality.
validateTriggerInvocationExpressionAfterArgument.
seidewitz
requested review from
hpdekoning
and removed request for
hpdekoning
hpdekoning
reviewed
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily implements the resolution to the following issue, as approved in SysML v2 FTF Ballot 6:
SYSML2-28 Validation constraints are missing in the SysML abstract syntax
The following issues with resolutions in Ballot 6 that were also relevant to validation actually did not require changes to the already implemented functionality (except for a slight change for SYSML2-298):
SYSML2-298 validateDefinitionVariationMembership and validateUsageVariationMembership are too strict
SYSML2-299 validateDefinitionVariationSpecialization and validateUsageVariationSpecialization OCL is wrong
SYSML2-300 validateDefinitionNonVariationMembership and validateUsageNonVariationMembership are redundant with validateVariantMembershipOwningNamespace
SYSML2-301 validateUsageOwningType constraint is too restrictive
SYSML2-302 validateOccurrenceUsageIndividualDefinition OCL is wrong
SYSML2-306 validateStateDefinitionIsParallelGeneralization and validateStateUsageIsParallelGeneralization constraints are too restrictive
Updates to
SysMLValidatorConstraints from the resolution to issue SYSML2-28, which were already implemented:
validateUsageIsReferential(satisfied automatically)validateExhibitStateUsageReferencevalidateIncludeUseCaseUsageReferenceConstraints added from the resolution to issue SYSML2-28:
validateAssignmentActionUsageArgumentsvalidateAssignmentActionUsageReferentvalidateTriggerInvocationExpressionAfterArgumentvalidateTriggerInvocationExpressionAtArgumentvalidateTriggerInvocationExpressionWhenArgumentvalidateForLoopActionUsageLoopVariablevalidateForLoopActionUsageParametersvalidateIfActionUsageParametersvalidateWhileLoopActionUsagevalidateAssertConstraintUsageReference*validateSatisfyRequirementUsageReference* See PR ST6RI-709 (Update) Resolutions from SysML v2 FTF Ballot #6 #507
Constraints from the resolution of issues SYSML2-298, 299 and 302, which were already implemented:
validateDefinitionVariationOwnedFeatureMemberships– Implementation was updated to cover all owned features, not just owned usagesvalidateDefinitionVariationSpecializationvalidateUsageVariationOwnedFeatureMemberships– Implementation was updated to cover all owned features, not just owned usagesvalidateUsageVariationSpecializationvalidateOccurrenceUsageIndividualDefinitionConstraints removed by the resolutions of issues SYSML2-300, 301 and 306, which were already commented out in the implementation:
validateDefinitionNonVariationMembershipvalidateUsageNonVariationMembershipvalidateUsageOwningTypevalidateStateDefinitionIsParallelGeneralizationvalidateStateUsageIsParallelGeneralizationAdditional updates
Minor updates were made to the implementation to follow more closely the OCL in the resolutions to the following issues from Ballot 6:
SYSML2-190 The description and derivation of ForLoopActionUsage::seqArgument is wrong
SYSML2-253 Additional cases when usages are required to be referential
SYSML2-356 The OCL for the body of ConstraintUsage::namingFeature is incorrect
New constraints implemented in the
SysMLValidatorresulted in the identification of other issues in need of resolution. These have been reported as new SysML v2 FTF issues. However, in order to successfully build, proposed resolutions for these issues have been implemented in this PR. Note that these resolutions have not yet been approved by the FTFs and, therefore, are subject to change.SYSML2-495 Textual notation BNF for TriggerExpression is wrong
SYSML2-497 validateTriggerInvocationExpressionAfterArgument constraint is too strong
SYSML2-498 validateTriggerInvocationExpressionWhenArgument constraint is wrong
SYSML2-499 Assignments parsed without a target will fail validateAssignmentActionUsageArguments
SYSML2-500 The derivation of AssignmentActionUsage::referent is wrong