Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Duplicate Mitochondrial Linoleic and Gamma-Linolenic Acid Beta-Oxidation Pathways #793

Merged
merged 22 commits into from
Apr 23, 2024

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As proposed in #761:

  • Removes MAR05358 for being a duplicate of MAR03452 + MAR03453 + MAR03454 + MAR03455
  • Removes MAR05195 for being a duplicate of MAR03456
  • Removes MAR05302 for being a duplicate of MAR03457
  • Removes MAR05229 for being a duplicate of MAR03458
  • Removes MAR05208 for being a duplicate of MAR03281 + MAR03282 + MAR03283
  • Removes MAR05356 for being a duplicate of MAR03275 + MAR03277 + MAR03278 + MAR03279
  • Removes MAR05191 for being a duplicate of MAR03280 + MAR03281 + MAR03282 + MAR03283
  • Removes MAR05123 for being a duplicate of MAR03284 + MAR03285 + MAR03286 + MAR03287
  • Removes MAR05075 for being a duplicate of MAR03288
  • Removes MAR05072 for being a duplicate of MAR03290 + MAR03292 + MAR03293
  • Replaces MAM03274m with MAM00091m in MAR05360
  • Removes MAM03274m for being a duplicate of MAM00091m
  • Removes MAM03653m for being a duplicate of MAM00072m
  • Removes MAM03221m for being a duplicate of MAM00089m
  • Removes MAM03182m for being a duplicate of MAM03009m
  • Removes MAM03978m for being a duplicate of MAM01576m
  • Removes MAM03203m for being a duplicate of MAM01575m
  • Removes MAM02698m for being a duplicate of MAM03021m
  • Removes MAM03650m for being a duplicate of MAM01577m

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

model/reactions.tsv Show resolved Hide resolved
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feiranl
Copy link
Collaborator

feiranl commented Apr 23, 2024

@JHL-452b Could you also review this PR?

@JHL-452b
Copy link
Collaborator

@JHL-452b Could you also review this PR?

I've finished checking and all implementation matchs with the claims in PR message.

@feiranl feiranl merged commit c5d4835 into develop Apr 23, 2024
8 checks passed
@feiranl feiranl deleted the fix/dupe_linoleoyl_gamma_linolenoyl_beta_ox_paths branch April 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants