Skip to content

add stairs as a contributor - #413

Merged
mihai-sysbio merged 2 commits into
mainfrom
all-contributors/add-stairs
Sep 15, 2022
Merged

add stairs as a contributor#413
mihai-sysbio merged 2 commits into
mainfrom
all-contributors/add-stairs

Conversation

@allcontributors

Copy link
Copy Markdown
Contributor

Adds @stairs as a contributor for bug.

This was requested by mihai-sysbio in this comment

@mihai-sysbio
mihai-sysbio changed the base branch from main to develop September 15, 2022 09:04
@mihai-sysbio
mihai-sysbio changed the base branch from develop to main September 15, 2022 09:05
@haowang-bioinfo

Copy link
Copy Markdown
Contributor

If such PR has to be made toward main branch?

@mihai-sysbio

Copy link
Copy Markdown
Member

If such PR has to be made toward main branch?

Changing the branch to develop requires then manual work to rebase or cherry-pick the commits on a new branch, otherwise a lot of commits show up. Do you feel up to doing this the "proper" way @haowang-bioinfo?

@haowang-bioinfo

Copy link
Copy Markdown
Contributor

@mihai-sysbio do what you think is best - no need to stick with "proper" way

@mihai-sysbio

Copy link
Copy Markdown
Member

@mihai-sysbio do what you think is best - no need to stick with "proper" way

I would merge now, so that the default main branch reflects the reality of the contribution and create an issue to find a way to deal with how the bot adds these contributions.

@haowang-bioinfo
haowang-bioinfo self-requested a review September 15, 2022 09:19
@mihai-sysbio
mihai-sysbio merged commit 199873e into main Sep 15, 2022
@mihai-sysbio
mihai-sysbio deleted the all-contributors/add-stairs branch September 15, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants