Human v1.1.1 - #134
Merged
Merged
Conversation
Function accounts for changes to metabolite related fields in addition to reaction-related fields
This new function works with the new "docModelChanges" function.
To be more consistent with Cobra structure
To avoid clashing with the new "writecell" function introduced in MATLAB R2019a
These plotting functions were added 5 months ago, but this repo does not seem an appropriate location for such functions.
Doc model changes
the "today" command requires the Financial Toolbox to be installed, whereas "clock" is in the base Matlab installation.
also fix ChEBI ID formatting
Annotation of model rxns, mets, and genes
Add exchange rxns
style: capitalize model filenames
This update is implemented by running script `curateExchangeRxns_issue117.m`: - a number of exchange reactions and involved metabolites are modified, as addressed in #117 - 8 new exchange rxns are added - HMR_9736 is determined as redundant and removed - 4 mets are renamed, 8 new mets are added - All modifications are saved to `curateExchangeRxns_issue117` and `curateExchangeRxns_issue117` for tracking the changes
JonathanRob
approved these changes
Sep 24, 2019
JonathanRob
left a comment
JonathanRob
left a comment
Collaborator
There was a problem hiding this comment.
Ok, these changes all look good, though I guess there is a conflict with some of the model files and the updateGrRules function that need to be resolved first.
Contributor
Author
|
@JonathanRob yes, but it is easy to solve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
annotateModelfor adding reaction, metabolite, and/or gene annotation information