refactor processChunk function #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavoguimaraes
requested review from
WillPapper,
daniilrrr,
ericvelazquez and
ibremseth
daniilrrr
reviewed
Nov 4, 2024
Co-authored-by: Daniil R <daniil@syndicate.io>
gustavoguimaraes
added a commit
that referenced
this pull request
Nov 7, 2024
#41) * add 0x00 flag in the SC to flag uncompressed data * Update metabased-contracts/src/MetabasedSequencerChain.sol Co-authored-by: ibremseth <isaac@syndicate.io> * remove obsolete contract files used in experiments * fix files after revert some changes in MetabaseSequencerChain contract * remove uneeded test * add PR improvement suggestions * fix naming * edit READM# * refactor * save oz lib version * fix tests * remane processRawData to processTransactionRaw * remove processBulkRawTransactions() * edit natspec for clearer information * refactor processChunk function (#51) * refactor processChunk function * Update metabased-contracts/src/MetabasedSequencerChain.sol Co-authored-by: Daniil R <daniil@syndicate.io> * rename vars --------- Co-authored-by: Daniil R <daniil@syndicate.io> --------- Co-authored-by: ibremseth <isaac@syndicate.io> Co-authored-by: Daniil R <daniil@syndicate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
No but a diagram
What does this PR do?
It refactors the
processChunk()function based on the chat between @daniilrrr and I.change
processChunk()function signature.Does this PR introduce any breaking changes (API/schema)?
It changes the
processChunk()function sig.Do any environment variables need to be updated or added before deployment?
How can this PR be tested?
forge test