experiment cleanup + add 0x00 flag in the SC to flag uncompressed data #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavoguimaraes
requested review from
daniilrrr,
ericvelazquez and
ibremseth
Co-authored-by: ibremseth <isaac@syndicate.io>
…icateProtocol/metabased-rollup into add-flag-for-compressed-txs
|
@ibremseth , I added the PR suggestions. Thank you. I also deleted extra files in |
ibremseth
reviewed
Nov 4, 2024
daniilrrr
reviewed
Nov 5, 2024
WillPapper
approved these changes
Nov 7, 2024
WillPapper
changed the title
* refactor processChunk function * Update metabased-contracts/src/MetabasedSequencerChain.sol Co-authored-by: Daniil R <daniil@syndicate.io> * rename vars --------- Co-authored-by: Daniil R <daniil@syndicate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Yes
What does this PR do?
0x00to flag a uncompressed data.changes function sig, by adding a
boolparamDoes this PR introduce any breaking changes (API/schema)?
Yes. Function sigs in the MetabasedSequencerChain contract are changed.
Need to update the ABI of any services that uses this contract
How can this PR be tested?
forge test