Skip to content

Conversation

@macintoshplus
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

When this master version is used with Winzou State Machine Bundle 0.3 and Sylius dev-master, the dependency injection throw this exception:

[Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]                    
  The service "twig" has a dependency on a non-existent service "SM\Factory\FactoryInterface".

It's true because the service id is sm.factory and a alias is defined with same name.

The realy behavior need is define alias from sm.factory to interface if the service id sm.factory exists. And define alias fromt interface to sm.factory if service id sm.factory is not defined.

And same behavior for service sm.callback_factory and sm.callback.cascade_transition.

@macintoshplus macintoshplus requested a review from a team as a code owner September 29, 2020 21:29
@loic425
Copy link
Member

loic425 commented Sep 29, 2020

@macintoshplus
Copy link
Author

@loic425 Nice and good job. I close my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants