Skip to content

Conversation

@loic425
Copy link
Member

@loic425 loic425 commented Sep 9, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets allows update to Symfony 5
License MIT

This pull request replaces this one #174 and add tests for all state machine versions.
It's also for Symfony 5 support: #121

@loic425 loic425 requested a review from a team as a code owner September 9, 2020 07:43
@loic425 loic425 force-pushed the feature/test-multiple-state-machine-versions branch from 1687480 to 662e24f Compare September 9, 2020 07:46
@loic425
Copy link
Member Author

loic425 commented Sep 9, 2020

@lchrusciel @pamil
Do we need to keep 0.3 compatibility ? Cause I think we need a pollyfill for this error:
https://travis-ci.org/github/Sylius/SyliusResourceBundle/jobs/725499862#L572

@loic425 loic425 force-pushed the feature/test-multiple-state-machine-versions branch 2 times, most recently from 38130da to c44e9c4 Compare September 25, 2020 08:10
@loic425 loic425 force-pushed the feature/test-multiple-state-machine-versions branch from c44e9c4 to e231f16 Compare September 25, 2020 08:11
@loic425 loic425 force-pushed the feature/test-multiple-state-machine-versions branch from 8ecf3ad to f70aafc Compare September 25, 2020 10:58
@loic425
Copy link
Member Author

loic425 commented Sep 25, 2020

@pamil @lchrusciel IMHO, to improve that, it would be better to fix winzou/state-machine dependencies to twig
Cause it's not compatible with twig: ^3.0 due to deprecated \Twig_Extension removal.
https://github.com/winzou/state-machine/blob/0.3.3/composer.json

@pamil pamil merged commit 836f475 into Sylius:master Oct 12, 2020
@pamil
Copy link
Contributor

pamil commented Oct 12, 2020

Thanks, Loïc! 🎉

@loic425 loic425 deleted the feature/test-multiple-state-machine-versions branch October 12, 2020 12:48
pamil added a commit that referenced this pull request Oct 12, 2020
This PR was merged into the 1.7-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #121 
| License         | MIT

Depends on #182 


Commits
-------

228ce21 Fix phpstan errors
314867d Fix flash helper spec
a7e55b7 Fix coding standard
13af8ed Suppress psalm error
a7de993 Symfony 5 should not fail on Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants