LC0068: Assert permissions for page extension source table

BusinessCentral.LinterCop.Test/Rule0068.cs

@@ -36,6 +36,9 @@ public async Task HasDiagnostic(string testCase)
     [TestCase("ProcedureCallsInherentPermissionsProperty")]
     [TestCase("ProcedureCallsInherentPermissionsAttribute")]
     [TestCase("PageSourceTable")]
+#if !LessThenSpring2024
+    [TestCase("PageExtensionSourceTable")]
+#endif
 #if !LessThenFall2023RV1
     [TestCase("ProcedureCallsPermissionsPropertyFullyQualified")]
 #endif

BusinessCentral.LinterCop.Test/TestCases/Rule0068/NoDiagnostic/PageExtensionSourceTable.al

@@ -0,0 +1,25 @@
+pageextension 50000 MyPageExtension extends MyPage
+{
+    trigger OnOpenPage()
+    var
+        MyTable: Record MyTable;
+    begin
+        [|MyTable.FindFirst();|]
+        [|MyTable.Insert();|]
+        [|MyTable.Modify();|]
+        [|MyTable.Delete();|]
+    end;
+}
+
+page 50000 MyPage
+{
+    SourceTable = MyTable;
+}
+
+table 50000 MyTable
+{
+    fields
+    {
+        field(1; MyField; Integer) { }
+    }
+}

BusinessCentral.LinterCop/Design/Rule0068CheckObjectPermission.cs

@@ -116,13 +116,8 @@ private void CheckObjectPermission(OperationAnalysisContext ctx)
 
         ITableTypeSymbol targetTable = (ITableTypeSymbol)((IRecordTypeSymbol)variableType).OriginalDefinition;
 
-        if (ctx.ContainingSymbol.GetContainingApplicationObjectTypeSymbol()?.NavTypeKind == NavTypeKind.Page)
-        {
-            IPropertySymbol? sourceTableProperty = ctx.ContainingSymbol.GetContainingApplicationObjectTypeSymbol()?.GetProperty(PropertyKind.SourceTable);
-            if (sourceTableProperty is not null)
-                if (sourceTableProperty.Value == targetTable)
-                    return;
-        }
+        if (TargetTableIsPageSourceTable(ctx, targetTable))
+            return;
 
         if (variableType.ToString().ToLower().EndsWith("temporary") || (targetTable.TableType == TableTypeKind.Temporary)) return;
 
@@ -261,4 +256,28 @@ private bool TableHasInherentPermission(ITableTypeSymbol table, char requestedPe
 
         return false;
     }
+
+    private bool TargetTableIsPageSourceTable(OperationAnalysisContext ctx, ITableTypeSymbol targetTable)
+    {
+        var applicationObjectTypeSymbol = ctx.ContainingSymbol.GetContainingApplicationObjectTypeSymbol();
+        if (applicationObjectTypeSymbol is not null)
+        {
+            IPropertySymbol? sourceTableProperty = null;
+            switch (applicationObjectTypeSymbol.GetNavTypeKindSafe())
+            {
+                case NavTypeKind.Page:
+                    sourceTableProperty = applicationObjectTypeSymbol.GetProperty(PropertyKind.SourceTable);
+                    break;
+                case NavTypeKind.PageExtension:
+                    var extendedPageSymbol = ((IPageExtensionTypeSymbol)applicationObjectTypeSymbol).Target;
+                    if (extendedPageSymbol is not null)
+                        sourceTableProperty = extendedPageSymbol.GetProperty(PropertyKind.SourceTable);
+                    break;
+            }
+            if (sourceTableProperty is not null)
+                if (sourceTableProperty.Value == targetTable)
+                    return true;
+        }
+        return false;
+    }
 }