Conversation
TimHess
commented
Jun 7, 2024
bart-vmware
reviewed
Jun 13, 2024
bart-vmware
reviewed
Jun 19, 2024
Member
bart-vmware
left a comment
There was a problem hiding this comment.
Great to see the new Steeltoe extensions in use!
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
bart-vmware
reviewed
Jun 20, 2024
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
bart-vmware
approved these changes
Jun 21, 2024
Member
bart-vmware
left a comment
There was a problem hiding this comment.
Nice, looks great!
I'll push another commit to run code-cleanup.
And one that fixes the ConfigServer sample (the .net version got bumped)
This was referenced Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update security samples to .NET 8, combine JWT and Certificate services into one, add instructions for running a UAA server