[pull] main from apache:main

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Improve SQL parsing and error handling in DataFusion, with minor updates to benchmark queries and test files

Bug Fixes:

• Enhance recursion limit error message to include the current limit
• Add explicit type casting in Clickbench queries to resolve potential type comparison issues

Enhancements:

• Add SqlParserOptions to DFParser to track recursion limit
• Implement a consistent statement parsing method with improved error handling for recursion limits

Chores:

• Update benchmark query syntax to improve type safety and clarity

[gitstream-cm]

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 7661/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the SQL parsing logic to improve error handling, particularly for recursion limits, and fixes a type casting issue in a Clickbench query. The parsing logic changes introduce a helper function to handle statement parsing and error messages. The Clickbench query fix ensures correct type casting for the levenshtein function.

Sequence diagram for parsing a SQL statement

sequenceDiagram
  participant DFParser
  participant Parser
  DFParser->>Parser: parse_statement()
  alt No RecursionLimitExceeded
    Parser-->>DFParser: Statement
    DFParser->>DFParser: Statement::Statement(Box::from(stmt))
    DFParser-->>DFParser: Result<Statement, DataFusionError>
  else RecursionLimitExceeded
    Parser-->>DFParser: ParserError::RecursionLimitExceeded
    DFParser->>DFParser: DataFusionError::SQL(ParserError::RecursionLimitExceeded)
    DFParser-->>DFParser: Result<Statement, DataFusionError>
  end

Loading

Updated class diagram for DFParser

classDiagram
  class DFParser {
    parser: Parser
    options: SqlParserOptions
    +parse_statement() Result<Statement, DataFusionError>
    +parse_copy() Result<Statement, DataFusionError>
    +parse_expr_with_alias() Result<Expr, DataFusionError>
    +parse_and_handle_statement() Result<Statement, DataFusionError>
  }
  class SqlParserOptions {
    recursion_limit: usize
  }
  DFParser -- SqlParserOptions : has a

Loading

File-Level Changes

Change	Details	Files
Refactors the parsing logic to handle recursion limits more consistently and provide more informative error messages.	Adds a SqlParserOptions struct to hold parser configuration. Introduces a parse_and_handle_statement helper function to encapsulate statement parsing and error handling, specifically for recursion limit errors. Modifies the error message for RecursionLimitExceeded to include the current recursion limit.	datafusion/sql/src/parser.rs
Fixes a type casting issue in a Clickbench query to ensure compatibility with the levenshtein function.	Adds an explicit cast CAST("UTMSource" AS STRING) and CAST("UTMCampaign" AS STRING) to the levenshtein function call in the Clickbench query.	benchmarks/queries/clickbench/README.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.