Conversation
* fix: parquet coerce_int96 schema * move test to parquet.slt * update based on comphead's suggestion
Reviewer's Guide by SourceryThis pull request introduces the Sequence diagram for fetching schema with coerce_int96sequenceDiagram
participant Client
participant ParquetFormat
participant ObjectStore
participant fetch_schema_with_location
participant fetch_schema
Client->>ParquetFormat: Get schema for Parquet file
ParquetFormat->>fetch_schema_with_location: fetch_schema_with_location(store, file, metadata_size_hint, coerce_int96)
fetch_schema_with_location->>ObjectStore: Fetch metadata
ObjectStore-->>fetch_schema_with_location: Metadata
fetch_schema_with_location->>fetch_schema: fetch_schema(store, file, metadata_size_hint, coerce_int96)
fetch_schema->>ObjectStore: Fetch Parquet metadata
ObjectStore-->>fetch_schema: Parquet metadata
fetch_schema->>fetch_schema: Infer schema from metadata
alt coerce_int96 is Some
fetch_schema->>fetch_schema: coerce_int96_to_resolution(schema, time_unit)
end
fetch_schema-->>fetch_schema_with_location: Schema
fetch_schema_with_location-->>ParquetFormat: Schema
ParquetFormat-->>Client: Schema
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* dissallow pushdown of volatile PhysicalExprs * fix * add FilteredVec helper to handle filter / remap pattern (#34) * checkpoint: Address PR feedback in https://github.com/apach... * add FilteredVec to consolidate handling of filter / remap pattern * lint * Add slt test for pushing volatile predicates down (#35) --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Add support for coercing INT96 timestamp types in Parquet file schema reading
New Features:
Enhancements: