Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix wrong cast from double to decimal when using "create table as select" statement to create hive table (backport #42350) #43355

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[BugFix] Fix wrong cast from double to decimal when using "create table as select" statement to create hive table (backport #42350) #43355

merged 1 commit into from
Mar 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

create table as:
image

create table like:
image

Source table:
image

What I'm doing:

Fixes #42671

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5
This is an automatic backport of pull request #42350 done by [Mergify](https://mergify.com). ## Why I'm doing: create table as: ![image](https://github.com/StarRocks/starrocks/assets/35512473/4e3699df-f078-48b5-b291-da21373a7631)

create table like:
image

Source table:
image

What I'm doing:

Fixes #42671

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mxdzs0612 @mergify
[BugFix] Fix wrong cast from double to decimal when using "create tab…
d98272c 
…le as select" statement to create hive table (#42350)

Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
(cherry picked from commit 5c27b03)
@mergify mergify bot mentioned this pull request Mar 28, 2024
Merged
23 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 28, 2024 13:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wanpengfei-git wanpengfei-git merged commit b80b548 into branch-3.2 Mar 28, 2024
35 of 36 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-42350 branch March 28, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

Assignees
No one assigned
Labels
automerge version:3.2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirtysalt @wanpengfei-git @mxdzs0612