Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix wrong cast from double to decimal when using "create table as select" statement to create hive table #42350

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

mxdzs0612
Copy link
Contributor

@mxdzs0612 mxdzs0612 commented Mar 8, 2024

Why I'm doing:

create table as:
image

create table like:
image

Source table:
image

What I'm doing:

Fixes #42671

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mxdzs0612 mxdzs0612 requested a review from a team as a code owner March 8, 2024 09:51
@github-actions github-actions bot added the 3.2 label Mar 8, 2024
@mxdzs0612
Copy link
Contributor Author

@kangkaisen @Seaven @packy92 PTAL, thx~

@kangkaisen
Copy link
Collaborator

@mxdzs0612 Could you add the UT for this bug? Thanks.

kangkaisen
kangkaisen previously approved these changes Mar 20, 2024
Copy link
Contributor

@letian-jiang letian-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kangkaisen
kangkaisen previously approved these changes Mar 21, 2024
@kangkaisen
Copy link
Collaborator

TestSQLCases.testIcebergHadoopCatalog
Element counts were not equal:
First has 1, Second has 0:  'c0\\tDOUBLE\\tYes\\tfalse\\tNone\\t'
First has 0, Second has 1:  'c0\tDOUBLE\tYes\tfalse\tNone\t' : sql result not match:
- [SQL]: describe ice_hadoop116eb6925e404ab1a02ce81abbc49f13.ice_hadoop_db116eb6925e404ab1a02ce81abbc49f13.test_double_as;
- [exp]: ['c0\\tDOUBLE\\tYes\\tfalse\\tNone\\t']
- [act]: ['c0\tDOUBLE\tYes\tfalse\tNone\t']
---

Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
Copy link

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 9 / 9 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/analyzer/CTASAnalyzer.java 9 9 100.00% []

@mxdzs0612 mxdzs0612 requested a review from kangkaisen March 23, 2024 01:06
@mxdzs0612
Copy link
Contributor Author

TestSQLCases.testIcebergHadoopCatalog
Element counts were not equal:
First has 1, Second has 0:  'c0\\tDOUBLE\\tYes\\tfalse\\tNone\\t'
First has 0, Second has 1:  'c0\tDOUBLE\tYes\tfalse\tNone\t' : sql result not match:
- [SQL]: describe ice_hadoop116eb6925e404ab1a02ce81abbc49f13.ice_hadoop_db116eb6925e404ab1a02ce81abbc49f13.test_double_as;
- [exp]: ['c0\\tDOUBLE\\tYes\\tfalse\\tNone\\t']
- [act]: ['c0\tDOUBLE\tYes\tfalse\tNone\t']
---

@kangkaisen Done, PTAL

@kangkaisen kangkaisen enabled auto-merge (squash) March 28, 2024 12:57
@kangkaisen kangkaisen merged commit 5c27b03 into StarRocks:main Mar 28, 2024
47 checks passed
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Mar 28, 2024
Copy link
Contributor

mergify bot commented Mar 28, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 28, 2024
…le as select" statement to create hive table (#42350)

Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
(cherry picked from commit 5c27b03)
wanpengfei-git pushed a commit that referenced this pull request Mar 28, 2024
…le as select" statement to create hive table (backport #42350) (#43355)

Co-authored-by: Jiao Mingye <35512473+mxdzs0612@users.noreply.github.com>
@dirtysalt dirtysalt mentioned this pull request Mar 28, 2024
23 tasks
@mxdzs0612 mxdzs0612 deleted the fix_cast_double branch March 29, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong cast from double to decimal when using "create table as select" statement to create hive table
4 participants