Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Deltalake supports DLF catalog #41733

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[BugFix] Deltalake supports DLF catalog #41733

merged 1 commit into from
Feb 28, 2024

Conversation

mxdzs0612
Copy link
Contributor

Why I'm doing:

After #31839 is merged, we can not access delta-lake table through DLF catalog.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mxdzs0612 mxdzs0612 requested a review from a team as a code owner February 27, 2024 06:51
@github-actions github-actions bot added the 2.5 label Feb 27, 2024
@mxdzs0612
delta lake support dlf
8f00aa0 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/delta/DeltaLakeInternalMgr.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@miomiocat miomiocat enabled auto-merge (squash) February 28, 2024 03:37
@miomiocat miomiocat merged commit 633d721 into StarRocks:main Feb 28, 2024
40 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Feb 28, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Feb 28, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Feb 28, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Feb 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 28, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

@mxdzs0612 mxdzs0612 deleted the delta-dlf branch February 28, 2024 03:38
mergify bot pushed a commit that referenced this pull request Feb 28, 2024
@mxdzs0612 @mergify
[BugFix] Deltalake supports DLF catalog (#41733)
25d1800 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
(cherry picked from commit 633d721)
@mergify mergify bot mentioned this pull request Feb 28, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Feb 28, 2024
@mxdzs0612 @mergify
[BugFix] Deltalake supports DLF catalog (#41733)
d73fe79 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
(cherry picked from commit 633d721)
mergify bot pushed a commit that referenced this pull request Feb 28, 2024
@mxdzs0612 @mergify
[BugFix] Deltalake supports DLF catalog (#41733)
7a66ba6 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
(cherry picked from commit 633d721)
This was referenced Feb 28, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 28, 2024
@mxdzs0612 @mergify
[BugFix] Deltalake supports DLF catalog (#41733)
2ef6a30 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
(cherry picked from commit 633d721)
@mergify mergify bot mentioned this pull request Feb 28, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Feb 28, 2024
@mergify @mxdzs0612
[BugFix] Deltalake supports DLF catalog (backport #41733) (#41814)
324561d 
Co-authored-by: Jiao Mingye <35512473+mxdzs0612@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 28, 2024
@mergify @mxdzs0612
[BugFix] Deltalake supports DLF catalog (backport #41733) (#41816)
fd28a45 
Co-authored-by: Jiao Mingye <35512473+mxdzs0612@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 28, 2024
@mergify @mxdzs0612
[BugFix] Deltalake supports DLF catalog (backport #41733) (#41815)
7d9614d 
Co-authored-by: Jiao Mingye <35512473+mxdzs0612@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 28, 2024
@mergify @mxdzs0612
[BugFix] Deltalake supports DLF catalog (backport #41733) (#41817)
ee61b98 
Co-authored-by: Jiao Mingye <35512473+mxdzs0612@users.noreply.github.com>
Seaven pushed a commit to Seaven/starrocks that referenced this pull request Feb 28, 2024
@mxdzs0612 @Seaven
[BugFix] Deltalake supports DLF catalog (StarRocks#41733)
5ea299b 
Signed-off-by: Jiao Mingye <mxdzs0612@gmail.com>
Signed-off-by: Seaven <seaven_7@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@miomiocat miomiocat miomiocat approved these changes

Assignees

@mxdzs0612 mxdzs0612

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxdzs0612 @miomiocat @stephen-shelby