Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix deltalake glue catalog #31839

Merged
merged 2 commits into from
Oct 8, 2023
Merged

[BugFix] Fix deltalake glue catalog #31839

merged 2 commits into from
Oct 8, 2023

Conversation

letian-jiang
Copy link
Contributor

@letian-jiang letian-jiang commented Sep 26, 2023 •
edited
Loading

Fixes #32079

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.2 label Sep 26, 2023
@letian-jiang letian-jiang mentioned this pull request Oct 7, 2023
Closed
@letian-jiang
Fix deltalake glue catalog
18c855c 
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
@letian-jiang letian-jiang force-pushed the fix-unified-connector branch from dd8da33 to 18c855c Compare October 8, 2023 06:58
@letian-jiang
update
719dcf0 
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
@letian-jiang letian-jiang changed the title [BugFix] Fix issues of unified connector [BugFix] Fix deltalake glue catalog Oct 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
1.4% 1.4% Duplication

@Youngwb Youngwb enabled auto-merge (squash) October 8, 2023 07:50
@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 11 / 12 (91.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/delta/DeltaLakeInternalMgr.java 7 8 87.50% [58]
🔵 com/starrocks/connector/delta/DeltaLakeMetadataFactory.java 4 4 100.00% []

@Youngwb Youngwb merged commit 5f9c1ac into StarRocks:main Oct 8, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 8, 2023
@letian-jiang @mergify
[BugFix] Fix deltalake glue catalog (#31839)
fb0bae7 
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 5f9c1ac)
@mergify mergify bot mentioned this pull request Oct 8, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Oct 8, 2023
@letian-jiang @wanpengfei-git
[BugFix] Fix deltalake glue catalog (#31839)
0aefa51 
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 5f9c1ac)
@letian-jiang
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 8, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 8, 2023
@letian-jiang @mergify
[BugFix] Fix deltalake glue catalog (#31839)
3d4ffe3 
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 5f9c1ac)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/delta/DeltaLakeConnector.java
#	fe/fe-core/src/main/java/com/starrocks/connector/delta/DeltaLakeInternalMgr.java
#	fe/fe-core/src/main/java/com/starrocks/connector/delta/DeltaLakeMetadataFactory.java
@mergify mergify bot mentioned this pull request Dec 8, 2023
Closed
@letian-jiang letian-jiang mentioned this pull request Dec 8, 2023
Merged
22 tasks
Youngwb pushed a commit that referenced this pull request Dec 8, 2023
@letian-jiang
[BugFix][Cherry-Pick][Branch-3.1] Fix deltalake glue catalog (backport …
6d9cfde 
…#31839) (#36687)

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
mergify bot pushed a commit that referenced this pull request Dec 8, 2023
@letian-jiang @mergify
[BugFix][Cherry-Pick][Branch-3.1] Fix deltalake glue catalog (backport …
4915a83 
…#31839) (#36687)

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 6d9cfde)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/delta/DeltaLakeConnector.java
mergify bot pushed a commit that referenced this pull request Dec 8, 2023
@letian-jiang @mergify
[BugFix][Cherry-Pick][Branch-3.1] Fix deltalake glue catalog (backport …
79d8ba8 
…#31839) (#36687)

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 6d9cfde)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/delta/DeltaLakeConnector.java
This was referenced Dec 12, 2023
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Dec 12, 2023
@letian-jiang
[BugFix][Cherry-Pick][Branch-2.5] Fix deltalake glue catalog (backport …
e87407b 
…#31839) (#36849)

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Youngwb pushed a commit that referenced this pull request Dec 12, 2023
@letian-jiang
[BugFix][Cherry-Pick][Branch-3.0] Fix deltalake glue catalog (backport …
afcb090 
…#31839) (#36847)

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
@mxdzs0612 mxdzs0612 mentioned this pull request Feb 27, 2024
Merged
23 tasks
This was referenced Feb 28, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@Smith-Cruise Smith-Cruise Smith-Cruise approved these changes

@Youngwb Youngwb Youngwb approved these changes

Assignees

@letian-jiang letian-jiang

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glue unified catalog should not required hive URI
5 participants
@letian-jiang @wanpengfei-git @Youngwb @Smith-Cruise @stephen-shelby