Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support a fake BINARY in where clause syntax for BI #40545

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[Enhancement] Support a fake BINARY in where clause syntax for BI #40545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support a fake BINARY in where clause syntax for BI 
Signed-off-by: Astralidea <astralidea@163.com>
  • Loading branch information
@Astralidea
Astralidea committed Feb 1, 2024
commit 277975708aaa57547601c526d2c90463da18f894
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2250,7 +2250,7 @@ expressionSingleton
;

expression
: booleanExpression #expressionDefault
: (BINARY)? booleanExpression #expressionDefault
| NOT expression #logicalNot
| left=expression operator=(AND|LOGICAL_AND) right=expression #logicalBinary
| left=expression operator=(OR|LOGICAL_OR) right=expression #logicalBinary
Expand Down
17 changes: 17 additions & 0 deletions fe/fe-core/src/test/java/com/starrocks/analysis/SelectStmtTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,23 @@ void testDataGripSupport() throws Exception {
starRocksAssert.query(sql).explainQuery();
}

@Test
void testNavicatBinarySupport() throws Exception {
String sql = "SELECT ACTION_ORDER, \n" +
" EVENT_OBJECT_TABLE, \n" +
" TRIGGER_NAME, \n" +
" EVENT_MANIPULATION, \n" +
" EVENT_OBJECT_TABLE, \n" +
" DEFINER, \n" +
" ACTION_STATEMENT, \n" +
" ACTION_TIMING\n" +
"FROM information_schema.triggers\n" +
"WHERE BINARY event_object_schema = 'test_ods_inceptor' \n" +
" AND BINARY event_object_table = 'cus_ast_total_d_p' \n" +
"ORDER BY event_object_table";
starRocksAssert.query(sql).explainQuery();
}

@Test
void testEqualExprNotMonotonic() throws Exception {
ConnectContext ctx = UtFrameUtils.createDefaultCtx();
Expand Down
Loading