Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support a fake BINARY in where clause syntax for BI #40545

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[Enhancement] Support a fake BINARY in where clause syntax for BI #40545

merged 1 commit into from
Feb 2, 2024

Conversation

Astralidea
Copy link
Contributor

Why I'm doing:
navicat will send a sql

SELECT ACTION_ORDER,
       EVENT_OBJECT_TABLE,
       TRIGGER_NAME,
       EVENT_MANIPULATION,
       EVENT_OBJECT_TABLE,
       DEFINER,
       ACTION_STATEMENT,
       ACTION_TIMING
FROM information_schema.triggers
WHERE BINARY event_object_schema = 'test_ods_inceptor'
  AND BINARY event_object_table = 'cus_ast_total_d_p'
ORDER BY event_object_table

will throw
ERROR 1064 (HY000): Getting syntax error at line 3, column 66. Detail message: Unexpected input 'event_object_table', the most similar input is {, ';'}.

What I'm doing:
Support a fake binary syntax so that this SQL can be executed normally. If there are users who need to support this syntax later, we will consider submitting another PR.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Astralidea <astralidea@163.com>
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Feb 1, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Feb 1, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Astralidea Astralidea enabled auto-merge (squash) February 2, 2024 01:44
@Astralidea Astralidea merged commit 935e407 into StarRocks:main Feb 2, 2024
44 checks passed
Copy link

github-actions bot commented Feb 2, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Feb 2, 2024
Copy link
Contributor

mergify bot commented Feb 2, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Feb 2, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 2, 2024
…0545)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 935e407)
mergify bot pushed a commit that referenced this pull request Feb 2, 2024
…0545)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 935e407)
wanpengfei-git pushed a commit that referenced this pull request Feb 5, 2024
…ckport #40545) (#40585)

Co-authored-by: Xueyan Li <astralidea@163.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 10, 2024
…ckport #40545) (#40584)

Co-authored-by: Xueyan Li <astralidea@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants