Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix FE UT http port conflict when running in parallel #34865

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[BugFix] fix FE UT http port conflict when running in parallel #34865

merged 1 commit into from
Nov 13, 2023

Conversation

kevincai
Copy link
Contributor

FE UT has http port conflict when running in parallel. Fix it by detecting useable port when running the case.

Introduced in #33371

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
[BugFix] fix FE UT http port conflict when running in parallel
1e7cda5 
Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kangkaisen kangkaisen merged commit 4982697 into StarRocks:main Nov 13, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 13, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 13, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 13, 2023
@kevincai @mergify
[BugFix] fix FE UT http port conflict when running in parallel (#34865)
fca8ae7 
Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
(cherry picked from commit 4982697)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/http/TransactionLoadActionOnSharedDataClusterTest.java
@mergify mergify bot mentioned this pull request Nov 13, 2023
Closed
mergify bot pushed a commit that referenced this pull request Nov 13, 2023
@kevincai @mergify
[BugFix] fix FE UT http port conflict when running in parallel (#34865)
b4a6fec 
Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
(cherry picked from commit 4982697)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/http/TransactionLoadActionOnSharedDataClusterTest.java
@mergify mergify bot mentioned this pull request Nov 13, 2023
Closed
kevincai added a commit to kevincai/starrocks that referenced this pull request Nov 13, 2023
@kevincai
[BugFix] fix FE UT http port conflict when running in parallel (StarR…
7c4a61a 
…ocks#34865)

Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
(cherry picked from commit 4982697)
@kevincai kevincai mentioned this pull request Nov 13, 2023
Merged
22 tasks
kevincai added a commit to kevincai/starrocks that referenced this pull request Nov 13, 2023
@kevincai
[BugFix] fix FE UT http port conflict when running in parallel (StarR…
90cedec 
…ocks#34865)

Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
(cherry picked from commit 4982697)
@kevincai kevincai mentioned this pull request Nov 13, 2023
Merged
22 tasks
kevincai added a commit to kevincai/starrocks that referenced this pull request Nov 13, 2023
@kevincai
[BugFix] fix FE UT http port conflict when running in parallel (StarR…
c5b4c02 
…ocks#34865)

Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
(cherry picked from commit 4982697)
@kevincai kevincai deleted the fix-fe-ut branch November 15, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@kevincai kevincai

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincai @kangkaisen @wanpengfei-git