[BugFix] fix FE UT http port conflict when running in parallel (#34865)

Signed-off-by: Kevin Cai <caixiaohua@starrocks.com>
StarRocks · Nov 13, 2023 · 4982697 · 4982697
1 parent 6226db5
commit 4982697
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/fe/fe-core/src/test/java/com/starrocks/http/StarRocksHttpTestCase.java b/fe/fe-core/src/test/java/com/starrocks/http/StarRocksHttpTestCase.java
@@ -128,6 +128,15 @@ public abstract class StarRocksHttpTestCase {
     @Mocked
     private static EditLog editLog;
 
+    public static int detectUsableSocketPort() {
+        try (ServerSocket socket = new ServerSocket(0)) {
+            socket.setReuseAddress(true);
+            return socket.getLocalPort();
+        } catch (Exception e) {
+            throw new IllegalStateException("Could not find a free TCP/IP port");
+        }
+    }
+
     public static OlapTable newTable(String name) {
         GlobalStateMgr.getCurrentInvertedIndex().clear();
         Column k1 = new Column("k1", Type.BIGINT);

diff --git a/...e-core/src/test/java/com/starrocks/http/TransactionLoadActionOnSharedDataClusterTest.java b/...e-core/src/test/java/com/starrocks/http/TransactionLoadActionOnSharedDataClusterTest.java
@@ -43,6 +43,7 @@
 public class TransactionLoadActionOnSharedDataClusterTest extends StarRocksHttpTestCase {
 
     private static HttpServer beServer;
+    private static int TEST_HTTP_PORT = 0;
 
     @Override
     @Before
@@ -58,7 +59,7 @@ public RunMode getCurrentRunMode() {
         ComputeNode computeNode = new ComputeNode(1234, "localhost", 8040);
         computeNode.setBePort(9300);
         computeNode.setAlive(true);
-        computeNode.setHttpPort(9737);
+        computeNode.setHttpPort(TEST_HTTP_PORT);
         GlobalStateMgr.getCurrentSystemInfo().addComputeNode(computeNode);
         new MockUp<GlobalStateMgr>() {
             @Mock
@@ -79,7 +80,8 @@ public static void close() {
 
     @BeforeClass
     public static void initBeServer() throws IllegalArgException, InterruptedException {
-        beServer = new HttpServer(9737);
+        TEST_HTTP_PORT = detectUsableSocketPort();
+        beServer = new HttpServer(TEST_HTTP_PORT);
         BaseAction ac = new BaseAction(beServer.getController()) {
 
             @Override

diff --git a/fe/fe-core/src/test/java/com/starrocks/http/TransactionLoadActionTest.java b/fe/fe-core/src/test/java/com/starrocks/http/TransactionLoadActionTest.java
@@ -44,14 +44,15 @@
 public class TransactionLoadActionTest extends StarRocksHttpTestCase {
 
     private static HttpServer beServer;
+    private static int TEST_HTTP_PORT = 0;
 
     @Override
     @Before
     public void setUp() {
         Backend backend4 = new Backend(1234, "localhost", 8040);
         backend4.setBePort(9300);
         backend4.setAlive(true);
-        backend4.setHttpPort(9737);
+        backend4.setHttpPort(TEST_HTTP_PORT);
         backend4.setDisks(new ImmutableMap.Builder<String, DiskInfo>().put("1", new DiskInfo("")).build());
         GlobalStateMgr.getCurrentSystemInfo().addBackend(backend4);
         new MockUp<GlobalStateMgr>() {
@@ -73,7 +74,9 @@ public static void close() {
 
     @BeforeClass
     public static void initBeServer() throws IllegalArgException, InterruptedException {
-        beServer = new HttpServer(9737);
+        TEST_HTTP_PORT = detectUsableSocketPort();
+
+        beServer = new HttpServer(TEST_HTTP_PORT);
         BaseAction ac = new BaseAction(beServer.getController()) {
 
             @Override