Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix partition live number not register #34842

Merged
merged 14 commits into from
Nov 16, 2023
Merged

[BugFix] Fix partition live number not register #34842

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9708e3b
Fix partition live number not register
Astralidea Nov 13, 2023
4ffe23d
Opt.
Astralidea Nov 13, 2023
19a8682
Opt.
Astralidea Nov 13, 2023
ff3e4e5
add UT.
Astralidea Nov 13, 2023
e1e7ed0
Merge branch 'StarRocks:main' into SR-22371
Astralidea Nov 13, 2023
296e5d4
Fix.
Astralidea Nov 14, 2023
ae9f8e8
Merge branch 'StarRocks:main' into SR-22371
Astralidea Nov 14, 2023
40247dc
Add more UT.
Astralidea Nov 14, 2023
917d9b3
Merge branch 'StarRocks:main' into SR-22371
Astralidea Nov 14, 2023
d7a14dd
Opt.
Astralidea Nov 15, 2023
73e8d0f
add UT.
Astralidea Nov 15, 2023
ed62cdc
Merge branch 'StarRocks:main' into SR-22371
Astralidea Nov 15, 2023
1b62c5e
Merge branch 'main' into SR-22371
Astralidea Nov 15, 2023
608ade5
Fix UT.
Astralidea Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix partition live number not register 
Signed-off-by: Astralidea <astralidea@163.com>
  • Loading branch information
@Astralidea
Astralidea committed Nov 13, 2023
commit 9708e3b64b43a62b1a93808e5a74a728af35594d
9 changes: 8 additions & 1 deletion fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3984,7 +3984,7 @@ public void modifyTableDynamicPartition(Database db, OlapTable table, Map<String
public void alterTableProperties(Database db, OlapTable table, Map<String, String> properties)
throws DdlException {
Map<String, String> logProperties = new HashMap<>(properties);
int partitionLiveNumber = -1;
int partitionLiveNumber = TableProperty.INVALID;
if (properties.containsKey(PropertyAnalyzer.PROPERTIES_PARTITION_LIVE_NUMBER)) {
try {
partitionLiveNumber = PropertyAnalyzer.analyzePartitionLiveNumber(properties, true);
Expand Down Expand Up @@ -4014,6 +4014,13 @@ public void alterTableProperties(Database db, OlapTable table, Map<String, Strin
if (logProperties.containsKey(PropertyAnalyzer.PROPERTIES_PARTITION_LIVE_NUMBER)) {
tableProperty.getProperties().put(PropertyAnalyzer.PROPERTIES_PARTITION_LIVE_NUMBER,
String.valueOf(partitionLiveNumber));
if (partitionLiveNumber == TableProperty.INVALID) {
GlobalStateMgr.getCurrentState().getDynamicPartitionScheduler().removeTtlPartitionTable(db.getId(),
table.getId());
} else {
GlobalStateMgr.getCurrentState().getDynamicPartitionScheduler().registerTtlPartitionTable(db.getId(),
table.getId());
}
tableProperty.setPartitionTTLNumber(partitionLiveNumber);
} else if (logProperties.containsKey(PropertyAnalyzer.PROPERTIES_STORAGE_MEDIUM)) {
TStorageMedium storageMedium = dataProperty.getStorageMedium();
Expand Down