[BugFix] Fix partition live number not register #34842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Astralidea <astralidea@163.com>
Actually, what others expect is how you fixed the issue not just the result. Then they can review your code with the understanding of what you have done. |
imay
reviewed
Nov 13, 2023
fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Astralidea <astralidea@163.com>
fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| ModifyTablePropertyOperationLog info = |
There was a problem hiding this comment.
Why write multi edit log instead of only one?
There was a problem hiding this comment.
Because this can only support one log and one process.
fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
[FE Incremental Coverage Report]✅ pass : 60 / 60 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
nshangyiming
approved these changes
Nov 15, 2023
gengjun-git
approved these changes
Nov 16, 2023
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Why I'm doing: Creating the table first and then changing the partition_live_number attribute does not take effect. What I'm doing: This is caused by not registering the schedule info in DynamicPartitionScheduler when modifying the properties. Adding this schedule info when modifying partition_live_number can solve the problem. Signed-off-by: Astralidea <astralidea@163.com> (cherry picked from commit 035e033) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Why I'm doing: Creating the table first and then changing the partition_live_number attribute does not take effect. What I'm doing: This is caused by not registering the schedule info in DynamicPartitionScheduler when modifying the properties. Adding this schedule info when modifying partition_live_number can solve the problem. Signed-off-by: Astralidea <astralidea@163.com> (cherry picked from commit 035e033) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Why I'm doing: Creating the table first and then changing the partition_live_number attribute does not take effect. What I'm doing: This is caused by not registering the schedule info in DynamicPartitionScheduler when modifying the properties. Adding this schedule info when modifying partition_live_number can solve the problem. Signed-off-by: Astralidea <astralidea@163.com> (cherry picked from commit 035e033) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
This was referenced Nov 16, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Creating the table first and then changing the partition_live_number attribute does not take effect.
What I'm doing:
This is caused by not registering the schedule info in DynamicPartitionScheduler when modifying the properties. Adding this schedule info when modifying
partition_live_numbercan solve the problem.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: