Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] reduce StarOSAgent lock contention #34788

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[Enhancement] reduce StarOSAgent lock contention #34788

merged 1 commit into from
Nov 10, 2023

Conversation

kevincai
Copy link
Contributor

  • optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
[Enhancement] reduce StarOSAgent lock contention
24a0438 
* optimize the lock usage in prepare(), the serviceId will not be
  updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@github-actions github-actions bot added the 3.2 label Nov 10, 2023
@sduzh sduzh enabled auto-merge (squash) November 10, 2023 08:54
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 6 / 7 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/lake/StarOSAgent.java 6 7 85.71% [105]

@sduzh sduzh merged commit 46e3509 into StarRocks:main Nov 10, 2023
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.1 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 10, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@kevincai @mergify
[Enhancement] reduce StarOSAgent lock contention (#34788)
6377776 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@kevincai @mergify
[Enhancement] reduce StarOSAgent lock contention (#34788)
ebab17f 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@kevincai @mergify
[Enhancement] reduce StarOSAgent lock contention (#34788)
52cd75e 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
This was referenced Nov 10, 2023
Merged
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@kevincai @wanpengfei-git
[Enhancement] reduce StarOSAgent lock contention (#34788)
f1dc7c4 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@kevincai @wanpengfei-git
[Enhancement] reduce StarOSAgent lock contention (#34788)
05425b4 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
andyziye pushed a commit that referenced this pull request Nov 13, 2023
@kevincai @andyziye
[Enhancement] reduce StarOSAgent lock contention (#34788)
cf6379c 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
andyziye pushed a commit that referenced this pull request Nov 14, 2023
@kevincai @andyziye
[Enhancement] reduce StarOSAgent lock contention (#34788)
6119999 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@kevincai @wanpengfei-git
[Enhancement] reduce StarOSAgent lock contention (#34788)
635da44 
optimize the lock usage in prepare(), the serviceId will not be updated once non-empty.

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 46e3509)
@kevincai kevincai deleted the fix-starosagent-prepare-lock branch December 3, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh approved these changes

@starrocks-xupeng starrocks-xupeng starrocks-xupeng approved these changes

Assignees

@kevincai kevincai

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevincai @wyb @sduzh @starrocks-xupeng @wanpengfei-git