[Enhancement] reduce StarOSAgent lock contention (#34788)

optimize the lock usage in prepare(), the serviceId will not be updated once non-empty. Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
StarRocks · Nov 10, 2023 · 46e3509 · 46e3509
1 parent 7b3dd61
commit 46e3509
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/lake/StarOSAgent.java b/fe/fe-core/src/main/java/com/starrocks/lake/StarOSAgent.java
@@ -96,8 +96,18 @@ public boolean init(StarManagerServer server) {
     }
 
     private void prepare() {
-        try (LockCloseable lock = new LockCloseable(rwLock.writeLock())) {
-            if (serviceId.equals("")) {
+        if (!serviceId.isEmpty()) {
+            return;
+        }
+
+        try (LockCloseable ignored = new LockCloseable(rwLock.readLock())) {
+            if (!serviceId.isEmpty()) {
+                return;
+            }
+        }
+
+        try (LockCloseable ignored = new LockCloseable(rwLock.writeLock())) {
+            if (serviceId.isEmpty()) {
                 getServiceId();
             }
         }