Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Schema change ignoring PREPARED transaction may lead to data loss #34381

Merged
merged 2 commits into from
Nov 14, 2023
Merged

[BugFix] Schema change ignoring PREPARED transaction may lead to data loss #34381

merged 2 commits into from
Nov 14, 2023

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented Nov 6, 2023 •
edited
Loading

Fixes #34377

Schema change should wait if there are previous loads running, and it uses TransactionStatus to see whether a load is running. Now it only considers PREPARE and COMMITTED transactions to be running, but ignores the PREPARED transactions, and this may lead to data loss for transaction stream load while doing schema change concurrently.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned banmoy Nov 6, 2023
@banmoy banmoy changed the title [BugFix] Schema change ignoring PREPARED transaction may lead to data loss [BugFix] Schema change ignoring PREPARED transaction state may lead to data loss Nov 6, 2023
@banmoy banmoy changed the title [BugFix] Schema change ignoring PREPARED transaction state may lead to data loss [BugFix] Schema change ignoring PREPARED transaction may lead to data loss Nov 6, 2023
chaoyli
chaoyli previously approved these changes Nov 6, 2023
View reviewed changes
@banmoy
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
599d700 
… loss

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@banmoy
Add test
036e1f7 
Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/TransactionState.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) November 14, 2023 05:29
@meegoo meegoo merged commit f13f0e8 into StarRocks:main Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 14, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Nov 14, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @mergify
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
9fec473 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @mergify
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
c8004ef 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @mergify
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
a88f6d1 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @mergify
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
b4e1878 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @wanpengfei-git
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
27fce72 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @wanpengfei-git
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
59687bd 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @wanpengfei-git
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
6a71287 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2023
@banmoy @wanpengfei-git
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
bcb2b93 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
@banmoy @mergify
[BugFix] Schema change ignoring PREPARED transaction may lead to data…
583e265 
… loss (#34381)

Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
(cherry picked from commit f13f0e8)
(cherry picked from commit 6a71287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meegoo meegoo meegoo approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees

@banmoy banmoy

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema change while executing transaction stream load may lead to data loss
4 participants
@banmoy @meegoo @chaoyli @wanpengfei-git