[BugFix] Schema change ignoring PREPARED transaction may lead to data…

… loss (#34381) Signed-off-by: PengFei Li <lpengfei2016@gmail.com>
StarRocks · Nov 14, 2023 · f13f0e8 · f13f0e8
1 parent f2f290e
commit f13f0e8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/fe/fe-core/src/main/java/com/starrocks/transaction/TransactionState.java b/fe/fe-core/src/main/java/com/starrocks/transaction/TransactionState.java
@@ -387,7 +387,8 @@ public void setErrorReplicas(Set<Long> newErrorReplicas) {
     }
 
     public boolean isRunning() {
-        return transactionStatus == TransactionStatus.PREPARE || transactionStatus == TransactionStatus.COMMITTED;
+        return transactionStatus == TransactionStatus.PREPARE || transactionStatus == TransactionStatus.PREPARED ||
+                transactionStatus == TransactionStatus.COMMITTED;
     }
 
     public void setTabletCommitInfos(List<TabletCommitInfo> infos) {

diff --git a/fe/fe-core/src/test/java/com/starrocks/transaction/TransactionStateTest.java b/fe/fe-core/src/test/java/com/starrocks/transaction/TransactionStateTest.java
@@ -42,6 +42,7 @@
 import java.io.IOException;
 import java.util.HashMap;
 import java.util.HashSet;
+import java.util.Set;
 import java.util.UUID;
 
 public class TransactionStateTest {
@@ -150,4 +151,22 @@ LoadJobSourceType.BACKEND_STREAMING, new TxnCoordinator(TxnSourceType.BE, "127.0
         }
         Assert.assertTrue(readTransactionState.isNewFinish());
     }
+
+    @Test
+    public void testIsRunning() {
+        Set<TransactionStatus> nonRunningStatus = new HashSet<>();
+        nonRunningStatus.add(TransactionStatus.UNKNOWN);
+        nonRunningStatus.add(TransactionStatus.VISIBLE);
+        nonRunningStatus.add(TransactionStatus.ABORTED);
+
+        UUID uuid = UUID.randomUUID();
+        for (TransactionStatus status : TransactionStatus.values()) {
+            TransactionState transactionState = new TransactionState(1000L, Lists.newArrayList(20000L, 20001L),
+                    3000, "label123", new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits()),
+                    LoadJobSourceType.BACKEND_STREAMING, new TxnCoordinator(TxnSourceType.BE, "127.0.0.1"), 50000L,
+                    60 * 1000L);
+            transactionState.setTransactionStatus(status);
+            Assert.assertEquals(nonRunningStatus.contains(status), !transactionState.isRunning());
+        }
+    }
 }