Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Cherry-Pick][Branch-3.1] Enable partial update to be used with condition update(#30242) #30489

Merged

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Sep 6, 2023

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

…tarRocks#30242)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@mergify mergify bot assigned sevev Sep 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
12.5% 12.5% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😞 fail : 4 / 12 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/routineload/PulsarRoutineLoadJob.java 0 1 00.00% [414]
🔵 com/starrocks/load/Load.java 0 7 00.00% [138, 139, 140, 142, 144, 148, 151]
🔵 com/starrocks/planner/StreamLoadPlanner.java 1 1 100.00% []
🔵 com/starrocks/load/loadv2/LoadingTaskPlanner.java 1 1 100.00% []
🔵 com/starrocks/load/routineload/KafkaRoutineLoadJob.java 1 1 100.00% []
🔵 com/starrocks/sql/ast/LoadStmt.java 1 1 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 1 / 3 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/delta_writer.cpp 0 2 00.00% [226, 227]
🔵 src/storage/rowset_update_state.cpp 1 1 100.00% []

@decster decster merged commit a368a71 into StarRocks:branch-3.1 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants