Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Enable partial update to be used with condition update #30242

Merged
merged 4 commits into from
Sep 5, 2023
Merged

[Enhancement] Enable partial update to be used with condition update #30242

merged 4 commits into from
Sep 5, 2023

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Aug 31, 2023 •
edited by decster
Loading

Actually we can do partial update with condition update, but we reject it. This pr enable it.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@sevev
Enhancement: Enable partial update to be used with condition update
7dff67d 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@mergify mergify bot assigned sevev Aug 31, 2023
sevev added 3 commits August 31, 2023 19:54
@sevev
add test
fbf9da2 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
add test file
497e3e1 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev
updatge
52b8b37 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 134 Code Smells

0.0% 0.0% Coverage
0.2% 0.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 11 / 12 (91.67%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/routineload/PulsarRoutineLoadJob.java 0 1 00.00% [414]
🔵 com/starrocks/planner/StreamLoadPlanner.java 1 1 100.00% []
🔵 com/starrocks/load/loadv2/LoadingTaskPlanner.java 1 1 100.00% []
🔵 com/starrocks/load/routineload/KafkaRoutineLoadJob.java 1 1 100.00% []
🔵 com/starrocks/load/Load.java 7 7 100.00% []
🔵 com/starrocks/sql/ast/LoadStmt.java 1 1 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 1 / 3 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/delta_writer.cpp 0 2 00.00% [231, 232]
🔵 src/storage/rowset_update_state.cpp 1 1 100.00% []

@chaoyli chaoyli merged commit 9afa751 into StarRocks:main Sep 5, 2023
@decster
Copy link
Contributor

decster commented Sep 6, 2023

@mergify backport branch-3.1

@github-actions github-actions bot added the 3.1 label Sep 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 6, 2023
@sevev @mergify
[Enhancement] Enable partial update to be used with condition update (#…
c3732c9 
…30242)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

(cherry picked from commit 9afa751)

# Conflicts:
#	be/src/storage/delta_writer.cpp
@mergify mergify bot mentioned this pull request Sep 6, 2023
Closed
sevev added a commit to sevev/starrocks that referenced this pull request Sep 6, 2023
@sevev
[Enhancement] Enable partial update to be used with condition update (S…
10d609e 
…tarRocks#30242)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev added a commit to sevev/starrocks that referenced this pull request Sep 6, 2023
@sevev
[Enhancement] Enable partial update to be used with condition update (S…
cafd52c 
…tarRocks#30242)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
decster pushed a commit that referenced this pull request Sep 6, 2023
@sevev
[Enhancement] Enable partial update to be used with condition update (#…
a368a71 
…30242) (#30489)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
decster pushed a commit that referenced this pull request Sep 6, 2023
@sevev
[Enhancement] Enable partial update to be used with condition update (#…
0db883f 
…30242) (#30490)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@sevev @Jay-ju
[Enhancement] Enable partial update to be used with condition update (S…
4c05ca9 
…tarRocks#30242)

Actually, we can do a partial update with a condition update, but we reject it. This pr enables it.
@jaogoy jaogoy requested a review from yingtingdong September 14, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@chaoyli chaoyli chaoyli approved these changes

@yingtingdong yingtingdong Awaiting requested review from yingtingdong

Assignees

@sevev sevev

Labels
3.1 behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevev @wanpengfei-git @decster @chaoyli