unit test

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>

fe/fe-core/src/main/java/com/starrocks/connector/CatalogConnectorMetadata.java

@@ -79,18 +79,11 @@ private ConnectorMetadata metadataOfDb(String dBName) {
         return normal;
     }
 
-    private ConnectorMetadata metadataOfDb(long dbId) {
-        if (isInfoSchemaDb(dbId)) {
-            return informationSchema;
-        }
-        return normal;
-    }
-
     @Override
     public List<String> listDbNames() {
-        ImmutableList.Builder<String> builder = ImmutableList.builder();
-        return builder.addAll(this.informationSchema.listDbNames())
+        return ImmutableList.<String>builder()
                 .addAll(this.normal.listDbNames())
+                .addAll(this.informationSchema.listDbNames())
                 .build();
     }
 
@@ -170,26 +163,12 @@ public void dropDb(String dbName, boolean isForceDrop) throws DdlException, Meta
         normal.dropDb(dbName, isForceDrop);
     }
 
-    @Override
-    public Database getDb(long dbId) {
-        ConnectorMetadata metadata = metadataOfDb(dbId);
-        return metadata.getDb(dbId);
-    }
-
     @Override
     public Database getDb(String name) {
         ConnectorMetadata metadata = metadataOfDb(name);
         return metadata.getDb(name);
     }
 
-    @Override
-    public List<Long> getDbIds() {
-        ImmutableList.Builder<Long> builder = ImmutableList.builder();
-        return builder.addAll(this.informationSchema.getDbIds())
-                .addAll(this.normal.getDbIds())
-                .build();
-    }
-
     @Override
     public boolean createTable(CreateTableStmt stmt) throws DdlException {
         return normal.createTable(stmt);

fe/fe-core/src/test/java/com/starrocks/connector/CatalogConnectorMetadataTest.java

@@ -0,0 +1,210 @@
+// Copyright 2021-present StarRocks, Inc. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.starrocks.connector;
+
+import com.google.common.collect.ImmutableList;
+import com.starrocks.catalog.Database;
+import com.starrocks.catalog.Table;
+import com.starrocks.catalog.system.information.InfoSchemaDb;
+import com.starrocks.common.UserException;
+import com.starrocks.connector.informationschema.InformationSchemaMetadata;
+import com.starrocks.sql.ast.*;
+import mockit.Expectations;
+import mockit.Mocked;
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+public class CatalogConnectorMetadataTest {
+
+    private final InformationSchemaMetadata informationSchemaMetadata = new InformationSchemaMetadata("test_catalog");
+
+    @Test
+    void testListDbNames(@Mocked ConnectorMetadata connectorMetadata) {
+        new Expectations() {
+            {
+                connectorMetadata.listDbNames();
+                result = ImmutableList.of("test_db1", "test_db2");
+                times = 1;
+            }
+        };
+
+        CatalogConnectorMetadata catalogConnectorMetadata = new CatalogConnectorMetadata(
+                connectorMetadata,
+                informationSchemaMetadata
+        );
+
+        List<String> dbNames = catalogConnectorMetadata.listDbNames();
+        List<String> expected = ImmutableList.of("test_db1", "test_db2", InfoSchemaDb.DATABASE_NAME);
+        assertEquals(expected, dbNames);
+    }
+
+    @Test
+    void testListTableNames(@Mocked ConnectorMetadata connectorMetadata) {
+        new Expectations() {
+            {
+                connectorMetadata.listTableNames("test_db");
+                result = ImmutableList.of("test_tbl1", "test_tbl2");
+                times = 1;
+            }
+        };
+
+        CatalogConnectorMetadata catalogConnectorMetadata = new CatalogConnectorMetadata(
+                connectorMetadata,
+                informationSchemaMetadata
+        );
+
+        List<String> tblNames = catalogConnectorMetadata.listTableNames(InfoSchemaDb.DATABASE_NAME);
+        List<String> expected = ImmutableList.of("tables", "table_privileges", "referential_constraints", "key_column_usage", "routines", "schemata", "columns", "character_sets", "collations", "table_constraints", "engines", "user_privileges", "schema_privileges", "statistics", "triggers", "events", "views", "partitions", "column_privileges");
+        assertEquals(expected, tblNames);
+
+        tblNames = catalogConnectorMetadata.listTableNames("test_db");
+        expected = ImmutableList.of("test_tbl1", "test_tbl2");
+        assertEquals(expected, tblNames);
+    }
+
+    @Test
+    void testGetDb(@Mocked ConnectorMetadata connectorMetadata) {
+        new Expectations() {
+            {
+                connectorMetadata.getDb("test_db");
+                result = null;
+                times = 1;
+            }
+        };
+
+        CatalogConnectorMetadata catalogConnectorMetadata = new CatalogConnectorMetadata(
+                connectorMetadata,
+                informationSchemaMetadata
+        );
+
+        Database db = catalogConnectorMetadata.getDb("test_db");
+        assertNull(db);
+        assertNotNull(catalogConnectorMetadata.getDb(InfoSchemaDb.DATABASE_NAME));
+    }
+
+    @Test
+    void testDbExists(@Mocked ConnectorMetadata connectorMetadata) {
+        new Expectations() {
+            {
+                connectorMetadata.dbExists("test_db");
+                result = true;
+                times = 1;
+            }
+        };
+
+        CatalogConnectorMetadata catalogConnectorMetadata = new CatalogConnectorMetadata(
+                connectorMetadata,
+                informationSchemaMetadata
+        );
+
+        assertTrue(catalogConnectorMetadata.dbExists("test_db"));
+        assertTrue(catalogConnectorMetadata.dbExists(InfoSchemaDb.DATABASE_NAME));
+    }
+
+    @Test
+    void testGetTable(@Mocked ConnectorMetadata connectorMetadata) {
+        new Expectations() {
+            {
+                connectorMetadata.getTable("test_db", "test_tbl");
+                result = null;
+                times = 1;
+            }
+        };
+
+        CatalogConnectorMetadata catalogConnectorMetadata = new CatalogConnectorMetadata(
+                connectorMetadata,
+                informationSchemaMetadata
+        );
+
+        Table table = catalogConnectorMetadata.getTable("test_db", "test_tbl");
+        assertNull(table);
+        assertNotNull(catalogConnectorMetadata.getTable(InfoSchemaDb.DATABASE_NAME, "tables"));
+    }
+
+    @Test
+    void testMetadataRouting(@Mocked ConnectorMetadata connectorMetadata) throws UserException {
+        new Expectations() {
+            {
+                // the following methods are always routed to normal metadata
+                // therefore, we test if the normal metadata is called exactly once per method
+                times = 1;
+
+                connectorMetadata.clear();
+                connectorMetadata.listPartitionNames("test_db", "test_tbl");
+                connectorMetadata.dropTable(null);
+                connectorMetadata.refreshTable("test_db", null, null, false);
+                connectorMetadata.alterMaterializedView(null);
+                connectorMetadata.addPartitions(null, null, null);
+                connectorMetadata.dropPartition(null, null, null);
+                connectorMetadata.renamePartition(null, null, null);
+                connectorMetadata.createMaterializedView((CreateMaterializedViewStatement) null);
+                connectorMetadata.createMaterializedView((CreateMaterializedViewStmt) null);
+                connectorMetadata.dropMaterializedView(null);
+                connectorMetadata.alterMaterializedView(null);
+                connectorMetadata.refreshMaterializedView(null);
+                connectorMetadata.cancelRefreshMaterializedView("test_db", "test_mv");
+                connectorMetadata.createView(null);
+                connectorMetadata.alterView(null);
+                connectorMetadata.truncateTable(null);
+                connectorMetadata.alterTableComment(null, null, null);
+                connectorMetadata.finishSink("test_db", "test_tbl", null);
+                connectorMetadata.createTableLike(null);
+                connectorMetadata.createTable(null);
+                connectorMetadata.createDb("test_db");
+                connectorMetadata.dropDb("test_db", false);
+                connectorMetadata.getRemoteFileInfos(null, null, 0, null, null);
+                connectorMetadata.getPartitions(null, null);
+                connectorMetadata.getMaterializedViewIndex("test_db", "test_tbl");
+                connectorMetadata.getTableStatistics(null, null, null, null, null);
+            }
+        };
+
+        CatalogConnectorMetadata catalogConnectorMetadata = new CatalogConnectorMetadata(
+                connectorMetadata,
+                informationSchemaMetadata
+        );
+
+        catalogConnectorMetadata.clear();
+        catalogConnectorMetadata.listPartitionNames("test_db", "test_tbl");
+        catalogConnectorMetadata.dropTable(null);
+        catalogConnectorMetadata.refreshTable("test_db", null, null, false);
+        catalogConnectorMetadata.alterMaterializedView(null);
+        catalogConnectorMetadata.addPartitions(null, null, null);
+        catalogConnectorMetadata.dropPartition(null, null, null);
+        catalogConnectorMetadata.renamePartition(null, null, null);
+        catalogConnectorMetadata.createMaterializedView((CreateMaterializedViewStatement) null);
+        catalogConnectorMetadata.createMaterializedView((CreateMaterializedViewStmt) null);
+        catalogConnectorMetadata.dropMaterializedView(null);
+        catalogConnectorMetadata.alterMaterializedView(null);
+        catalogConnectorMetadata.refreshMaterializedView(null);
+        catalogConnectorMetadata.cancelRefreshMaterializedView("test_db", "test_mv");
+        catalogConnectorMetadata.createView(null);
+        catalogConnectorMetadata.alterView(null);
+        catalogConnectorMetadata.truncateTable(null);
+        catalogConnectorMetadata.alterTableComment(null, null, null);
+        catalogConnectorMetadata.finishSink("test_db", "test_tbl", null);
+        catalogConnectorMetadata.createTableLike(null);
+        catalogConnectorMetadata.createTable(null);
+        catalogConnectorMetadata.createDb("test_db");
+        catalogConnectorMetadata.dropDb("test_db", false);
+        catalogConnectorMetadata.getRemoteFileInfos(null, null, 0, null, null);
+        catalogConnectorMetadata.getPartitions(null, null);
+        catalogConnectorMetadata.getMaterializedViewIndex("test_db", "test_tbl");
+        catalogConnectorMetadata.getTableStatistics(null, null, null, null, null);
+    }
+}