-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support information schema for external catalog #27359
Conversation
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
d922509
to
8c86923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't let every connector to know about information schema. We can implement it transparently. Let's talk offline.
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
45a4a72
to
c5fb0d4
Compare
a few questions about design:
|
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorService.java
Outdated
Show resolved
Hide resolved
The code is well written. I have no questions about the code. |
Q1
Q2
|
fe/fe-core/src/main/java/com/starrocks/connector/CatalogConnectorMetadata.java
Show resolved
Hide resolved
Please give the clear definition of the |
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorService.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorService.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorService.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/connector/ConnectorService.java
Outdated
Show resolved
Hide resolved
5548e6e
to
ec55b88
Compare
ec55b88
to
959b0f2
Compare
Kudos, SonarCloud Quality Gate passed!
|
[FE PR Coverage Check]😍 pass : 246 / 290 (84.83%) file detail
|
This PR does the following
CatalogConnector
to aggregate normal connector and information schema connector with a single catalogWhat type of PR is this:
Checklist:
Bugfix cherry-pick branch check: