Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] disable RewriteMinMaxAggToMetaScanRule when table has deletion #16898

Merged
merged 1 commit into from
Jan 28, 2023
Merged

[BugFix] disable RewriteMinMaxAggToMetaScanRule when table has deletion #16898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../java/com/starrocks/sql/optimizer/rule/transformation/RewriteMinMaxAggToMetaScanRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,13 @@ public boolean check(final OptExpression input, OptimizerContext context) {
// 6. all arguments to agg functions are primitive columns
// 7. no expr in arguments to agg functions
// 8. all agg columns have zonemap index and are not null
// 9. no deletion happens
if (table.getKeysType() != KeysType.DUP_KEYS) {
return false;
}
if (table.hasDelete()) {
return false;
}
// no limit
if (scanOperator.getLimit() != -1) {
return false;
Expand Down