Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] disable RewriteMinMaxAggToMetaScanRule when table has deletion #16898

Merged
merged 1 commit into from
Jan 28, 2023
Merged

[BugFix] disable RewriteMinMaxAggToMetaScanRule when table has deletion #16898

merged 1 commit into from
Jan 28, 2023

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Jan 28, 2023 •
edited
Loading

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@silverbullet233
disable RewriteMinMaxAggToMetaScanRule when table has deletion
84ac2f7 
Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
@github-actions github-actions bot removed the be-build label Jan 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 1 / 2 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/RewriteMinMaxAggToMetaScanRule.java 1 2 50.00% [111]

@silverbullet233
Copy link
Contributor Author

run starrocks_admit_test

1 similar comment
@silverbullet233
Copy link
Contributor Author

run starrocks_admit_test

@kangkaisen kangkaisen merged commit 1def4c6 into StarRocks:main Jan 28, 2023
@github-actions github-actions bot removed the be-build label Jan 28, 2023
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Jan 28, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

HangyuanLiu pushed a commit to HangyuanLiu/starrocks that referenced this pull request Feb 1, 2023
@silverbullet233 @HangyuanLiu
[BugFix] Disable RewriteMinMaxAggToMetaScanRule when table has deleti…
0f80f1e 
…on (StarRocks#16898)

Signed-off-by: silverbullet233 <3675229+silverbullet233@users.noreply.github.com>
Signed-off-by: HangyuanLiu <460660596@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdpain stdpain stdpain approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees
No one assigned
Labels
Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverbullet233 @wanpengfei-git @kangkaisen @stdpain