Skip to content

Updates to install redis, so can be used as coordination backend #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2021

Conversation

amanda11
Copy link
Contributor

@amanda11 amanda11 commented Apr 27, 2021

Updates to make redis the default backend.

Introduced new role for redis, so that it can be remove or replaced if different coordination backend required.

ST2 unstable (and therefore 3.5) will come with libraries for redis client, and therefore redis can currently be enabled by setting st2_config ansible variable to define the coordination url.

Once bash installer also includes redis configuration, then we can make the default st2.conf specify redis url as the default

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Apr 27, 2021
@amanda11 amanda11 changed the title Updates to configure redis as coordination backend [WIP] Updates to configure redis as coordination backend Apr 27, 2021
@amanda11 amanda11 marked this pull request as draft April 27, 2021 20:33
@amanda11
Copy link
Contributor Author

amanda11 commented Apr 27, 2021

Not sure why tests on Ubuntu are failing when st2chatops needs the st2apikey. Have run the playbook successfully on an Ubuntu Bionic fresh VM and all passed. But also got that by looks on some CentOS runs, and then the later ones passed.

@arm4b arm4b added the feature label Apr 28, 2021
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Apr 29, 2021
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Apr 29, 2021
@amanda11
Copy link
Contributor Author

Found problem, with redis on Ubuntu. redis attempts to bind on both IPv4 and IPv6, but it fails to bind in our docker containers. Changing the bind to only be 127.0.0.1 works.
Will work on fix for playbooks.

@amanda11 amanda11 changed the title [WIP] Updates to configure redis as coordination backend Updates to configure redis as coordination backend Apr 29, 2021
@amanda11 amanda11 marked this pull request as ready for review April 29, 2021 21:53
@amanda11 amanda11 marked this pull request as draft April 30, 2021 07:51
@amanda11
Copy link
Contributor Author

In case of stable runs then we don't want coordination url to redis, as ST2 3.4.1 won't have relevant python libraries configured.

If the Travis run passes on the unstable with the latest changes, then I will take out the defaults for coordination url in st2_config parameter. So it won't use redis coordination url unless it's the default in st2.conf in the package.

This should then pass for unstable and stable, but ST2 won't actually be using redis. But we'll know the playbooks are setup to configure redis for when url is set to redis.

Can't change the deafult in st2.conf until we have the bash installer changes under StackStorm/st2-packages#698 merged. But once that is done we can make the co-ordination url default to redis.

@amanda11 amanda11 changed the title Updates to configure redis as coordination backend Updates to install redis, so can be used as coordination backend Apr 30, 2021
@amanda11 amanda11 marked this pull request as ready for review April 30, 2021 11:13
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

That's even better 👍, meaning [coordination] will automagically work once the Redis becomes the default backend in the upstream st2.conf.

@amanda11 amanda11 merged commit 5f1a63c into master Apr 30, 2021
@amanda11 amanda11 deleted the add_redis branch April 30, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants