Attributes by kashike · Pull Request #1428 · SpongePowered/SpongeAPI

kashike · 2016-12-09T21:59:05Z

simon816 · 2016-12-10T18:22:54Z

Aren't most of these things available (or can be made available) through the data API?

kashike · 2016-12-10T18:49:32Z

No.
http://minecraft.gamepedia.com/Attribute

Maxqia · 2016-12-11T21:05:56Z

ooooh, I don't have to use NMS anymore for this : https://github.com/Maxqia/MiscStuff/blob/master/src/main/java/com/maxqia/miscstuff/DisableAttackTime.java, btw your Common link is accidentally referencing SpongeAPI

src/main/java/org/spongepowered/api/entity/attribute/AttributeModifier.java

Cybermaxke · 2016-12-14T18:12:21Z

The Common refers to a wrong pr.

gabizou

Javadocs please.

src/main/java/org/spongepowered/api/entity/attribute/AttributeModifier.java

src/main/java/org/spongepowered/api/entity/attribute/operation/AttributeOperation.java

gabizou

Clarification in javadocs needed. Also, wouldn't this PR fit to have some events? Or usability with Data API being able to perform more modifications than just getting an Attribute instance from Living?

gabizou · 2017-02-25T16:59:59Z

src/main/java/org/spongepowered/api/entity/attribute/Attribute.java

+import java.util.UUID;
+
+/**
+ * An attribute instance.


Clarify? Is it just a container for some values? What does it represent? Who can own one?

gabizou · 2017-02-25T17:01:32Z

src/main/java/org/spongepowered/api/entity/attribute/AttributeModifier.java

+import java.util.UUID;
+
+/**
+ * An attribute modifier.


What are these for? What do they modify on an Attribute? How do they interact with each other?

gabizou · 2017-02-25T17:01:48Z

src/main/java/org/spongepowered/api/entity/attribute/operation/AttributeOperation.java

+import org.spongepowered.api.util.annotation.CatalogedBy;
+
+/**
+ * An attribute operation.


An operation that does "what"?

randombyte-developer · 2017-12-18T19:14:32Z

What's the status of this?

HaedHutner · 2017-12-19T10:36:48Z

Also interested in a status update on this. Will it make it into API7?

parlough · 2017-12-19T10:38:02Z

@HaedHutner @randombyte-developer I do not think so unfortunately, but I will see what I can do as this has been a popular request recently.

HaedHutner · 2017-12-19T10:43:18Z

@Meronat What else needs to be done on this? I'd be willing to help out

ryantheleach · 2018-01-27T11:42:29Z

Kashike has some changes locally on this that need to be finished, If anyone picks this up, I'd recommend contacting them first to see what direction it was heading in.

BrainStone · 2018-05-08T02:00:03Z

@kashike what's the status on this? I'd love to help out, as I really want to see this implemented!

Also knowing what needs to be done would be helpful. I'd highly apprechiate if you get in contact with me. If you don't mind I'd apprechiate getting write access to your branches, so I don't have to fork it myself and create another PR.

gabizou · 2018-05-08T02:22:52Z

@BrainStone I'd recommend forking and PR'ing due to the time difference since the original commit from kashike and the current "status" of the API. As the API has evolved since 2016, there are some concepts that need to be changed with how registrations are handled, and other things (look at the registration event for example, build new attributes and register them there). I'd say that it would be safe to start from there, and the implementation as well (can assist with updating the implementation to bring it "up to speed" with other changes, but definitely a "test" would be to write a test plugin that takes advantage of the API and operates with the basis of how the Attribute API can be used by plugins.

Faithcaio · 2018-06-23T13:17:38Z

@kashike status?

Cybermaxke · 2018-06-25T22:17:46Z

src/main/java/org/spongepowered/api/entity/attribute/type/AttributeTypes.java

+        public static final RangedAttributeType MAX_HEALTH = DummyObjectProvider.createFor(RangedAttributeType.class, "MAX_HEALTH");
+
+        public static final RangedAttributeType MOVEMENT_SPEED = DummyObjectProvider.createFor(RangedAttributeType.class, "MOVEMENT_SPEED");
+


Should we also support the generic.reachDistance attribute which is added by forge?

Is this something we can implement in vanilla? Does it need to be synced with the client?

It will work nicer that way yes, but you can also make it server side only by blocking interaction if the reach distance is below the client distance, or handle custom interaction if it's the other way around (could also just limit this to forge).

Cybermaxke · 2018-06-25T22:19:30Z

How can you get/set attribute modifiers on ItemStacks?

src/main/java/org/spongepowered/api/entity/attribute/type/RangedAttributeType.java

src/main/java/org/spongepowered/api/entity/living/Living.java

JBYoshi · 2019-06-08T22:42:04Z

How's this going? I saw a few people asking about this on the forums.

Sago92 · 2019-08-25T15:35:43Z

I am comming from the Sponge forum and I am looking forward for the completion of this implementation. This would be an essential part in my RPG pluing (for example manipulating attack speed of entities and so on ...) Any plan for the finish line?

SirFancyBacon · 2019-08-26T14:19:54Z

I also am looking for a way to adjust attack speed on entities.

Sago92 · 2019-10-08T20:03:37Z

Closed without any final statement? What is the future plan for the ItemStack attributes like attack speed?

gabizou · 2019-10-08T20:28:29Z

The branch needs to be rebased/recreated based on api-8. Bleeding and 1.13 are severely outdated, so they were deleted. Unfortunately, GitHub doesn't have a way to automatically re-target the PR's that were targeting those branches, so it auto-closes them. It'll be looked at after some deployments get working to build api-8, but for now this PR needs to be rebased and rebuilt.

kashike added the status: wip label Dec 9, 2016

kashike mentioned this pull request Dec 9, 2016

Attributes SpongePowered/Sponge#1064

Closed

Cybermaxke reviewed Dec 14, 2016

View reviewed changes

src/main/java/org/spongepowered/api/entity/attribute/AttributeModifier.java Show resolved Hide resolved

gabizou requested changes Dec 16, 2016

View reviewed changes

src/main/java/org/spongepowered/api/entity/attribute/AttributeModifier.java Show resolved Hide resolved

src/main/java/org/spongepowered/api/entity/attribute/operation/AttributeOperation.java Show resolved Hide resolved

gabizou requested changes Feb 25, 2017

View reviewed changes

parlough mentioned this pull request Aug 13, 2017

Implement Attribute Modifiers #1628

Closed

kashike mentioned this pull request Sep 27, 2017

APIs we should look into adding to Sponge over time for our own implementation purposes LanternPowered/Lantern#41

Open

10 tasks

Cybermaxke reviewed Jun 25, 2018

View reviewed changes

ST-DDT reviewed Jun 25, 2018

View reviewed changes

src/main/java/org/spongepowered/api/entity/attribute/type/RangedAttributeType.java Outdated Show resolved Hide resolved

Cybermaxke reviewed Jun 25, 2018

View reviewed changes

src/main/java/org/spongepowered/api/entity/living/Living.java Outdated Show resolved Hide resolved

gabizou added the branch: bleeding label Aug 30, 2018

kashike requested a review from stephan-gh as a code owner February 4, 2019 23:10

Attributes

a84b99d

gabizou closed this Oct 8, 2019

i509VCB mentioned this pull request Feb 2, 2020

Add Entity Attribute API [Redux of #1428] [API-8] #2085

Merged

		public static final RangedAttributeType MAX_HEALTH = DummyObjectProvider.createFor(RangedAttributeType.class, "MAX_HEALTH");

		public static final RangedAttributeType MOVEMENT_SPEED = DummyObjectProvider.createFor(RangedAttributeType.class, "MOVEMENT_SPEED");

Uh oh!

Conversation

kashike commented Dec 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simon816 commented Dec 10, 2016

Uh oh!

kashike commented Dec 10, 2016

Uh oh!

Maxqia commented Dec 11, 2016

Uh oh!

Uh oh!

Cybermaxke commented Dec 14, 2016

Uh oh!

gabizou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gabizou left a comment

Choose a reason for hiding this comment

Uh oh!

gabizou Feb 25, 2017

Choose a reason for hiding this comment

Uh oh!

gabizou Feb 25, 2017

Choose a reason for hiding this comment

Uh oh!

gabizou Feb 25, 2017

Choose a reason for hiding this comment

Uh oh!

randombyte-developer commented Dec 18, 2017

Uh oh!

HaedHutner commented Dec 19, 2017

Uh oh!

parlough commented Dec 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HaedHutner commented Dec 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryantheleach commented Jan 27, 2018

Uh oh!

BrainStone commented May 8, 2018

Uh oh!

gabizou commented May 8, 2018

Uh oh!

Faithcaio commented Jun 23, 2018

Uh oh!

Cybermaxke Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parlough Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

Cybermaxke Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

Cybermaxke commented Jun 25, 2018

Uh oh!

Uh oh!

Uh oh!

JBYoshi commented Jun 8, 2019

Uh oh!

Sago92 commented Aug 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SirFancyBacon commented Aug 26, 2019

Uh oh!

Sago92 commented Oct 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabizou commented Oct 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

kashike commented Dec 9, 2016 •

edited

Loading

parlough commented Dec 19, 2017 •

edited

Loading

HaedHutner commented Dec 19, 2017 •

edited

Loading

Cybermaxke Jun 25, 2018 •

edited

Loading

Sago92 commented Aug 25, 2019 •

edited

Loading

Sago92 commented Oct 8, 2019 •

edited

Loading