Attributes#1064
Attributes#1064kashike wants to merge 1 commit intoSpongePowered:bleedingfrom kashike:feature/attributes
Conversation
|
|
||
| import java.util.UUID; | ||
|
|
||
| @Implements(@Interface(iface = AttributeModifier.class, prefix = "modifier$")) |
|
|
||
| public static final AttributeOperation[] operations = new AttributeOperation[3]; | ||
| @RegisterCatalog(AttributeOperations.class) | ||
| public final Map<String, AttributeOperation> operationMap = Maps.newHashMap(); |
There was a problem hiding this comment.
Guava suggests you to use constructor since java7.
There was a problem hiding this comment.
Our practice across the entire repo is to use guava, not changing now.
|
|
||
| public class AttributeRegistryModule implements CatalogRegistryModule<AttributeType> { | ||
|
|
||
| private final Map<String, AttributeType> attributes = new HashMap<>(); |
There was a problem hiding this comment.
@Deamon5550 Then why do you use constructor here if you always uses guava?
There was a problem hiding this comment.
gabizou
left a comment
gabizou
left a comment
There was a problem hiding this comment.
Your intrinsic methods need to have prefixes with @Implements annotated on the mixing class.
|
|
||
| @Intrinsic | ||
| @Override | ||
| default double getDefaultValue() { |
There was a problem hiding this comment.
If this is intrinsic, it needs to be prefixed.
|
|
||
| @Intrinsic | ||
| @Override | ||
| default String getName() { |
There was a problem hiding this comment.
If this is intrinsic, needs to be prefixed.
|
Kashike has some changes locally on this that need to be finished, If anyone picks this up, I'd recommend contacting them first to see what direction it was heading in. |
|
This will need to be re-done and re-target |
5 participants
API | Common