-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify rule S5131: Add FastAPI (APPSEC-1250) #3386
Modify rule S5131: Add FastAPI (APPSEC-1250) #3386
Conversation
Quality Gate passed for 'rspec-tools'Kudos, no new issues are introduced in this PR! 0 New issues |
Quality Gate passed for 'rspec-frontend'Kudos, no new issues are introduced in this PR! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of content-types that allow for XSS is not consistent with the implementation ticket. I guess the list form the RSPEC needs to be updated.
(The RSPEC list of MIME types was not updated, instead the implementation ticket was changed to match the current RSPEC list.) |
This reverts commit 67d9172.
This reverts commit 67d9172.
…#3408) The PRs #3365, #3374, #3386, #3391 and #3392 were merged before implementation. This reverts them, to be merged only once implemented. ## Review A dedicated reviewer checked the rule description successfully for: - [ ] logical errors and incorrect information - [ ] information gaps and missing content - [ ] text style and tone - [ ] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
Review
A dedicated reviewer checked the rule description successfully for: