Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S5131: Add FastAPI (APPSEC-1250) #3386

Merged

Conversation

egon-okerman-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of content-types that allow for XSS is not consistent with the implementation ticket. I guess the list form the RSPEC needs to be updated.

@egon-okerman-sonarsource
Copy link
Contributor Author

(The RSPEC list of MIME types was not updated, instead the implementation ticket was changed to match the current RSPEC list.)

@egon-okerman-sonarsource egon-okerman-sonarsource merged commit 67d9172 into master Nov 6, 2023
11 checks passed
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the rule/S5131/python/add-fastapi-appsec-1250 branch November 6, 2023 10:04
egon-okerman-sonarsource added a commit that referenced this pull request Nov 6, 2023
egon-okerman-sonarsource added a commit that referenced this pull request Nov 6, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource restored the rule/S5131/python/add-fastapi-appsec-1250 branch November 6, 2023 15:55
egon-okerman-sonarsource added a commit that referenced this pull request Nov 6, 2023
…#3408)

The PRs #3365, #3374, #3386, #3391 and #3392 were merged before
implementation. This reverts them, to be merged only once implemented.

## Review

A dedicated reviewer checked the rule description successfully for:

- [ ] logical errors and incorrect information
- [ ] information gaps and missing content
- [ ] text style and tone
- [ ] PR summary and labels follow [the
guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants