Modify rule S4830: Add HTTPX support (APPSEC-1259) #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-teuchert-sonarsource
approved these changes
Oct 30, 2023
Co-authored-by: daniel-teuchert-sonarsource <141642369+daniel-teuchert-sonarsource@users.noreply.github.com>
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
egon-okerman-sonarsource
deleted the
rule/python/S4830/add-httpx-appsec-1259
branch
egon-okerman-sonarsource
added a commit
that referenced
this pull request
Nov 6, 2023
This reverts commit d735db0.
4 tasks
egon-okerman-sonarsource
added a commit
that referenced
this pull request
Nov 6, 2023
This reverts commit d735db0.
egon-okerman-sonarsource
restored the
rule/python/S4830/add-httpx-appsec-1259
branch
egon-okerman-sonarsource
added a commit
that referenced
this pull request
Nov 6, 2023
…#3408) The PRs #3365, #3374, #3386, #3391 and #3392 were merged before implementation. This reverts them, to be merged only once implemented. ## Review A dedicated reviewer checked the rule description successfully for: - [ ] logical errors and incorrect information - [ ] information gaps and missing content - [ ] text style and tone - [ ] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: